Fix plain text output not sorted correctly

Author: silvanocerza

Diff for: cli/lib/check_deps.go

@@ -83,10 +83,18 @@ func (dr checkDepResult) Data() interface{} {
 func (dr checkDepResult) String() string {
 	res := ""
 	deps := dr.deps.Dependencies
+
+	// Sort depedencies alphabetically and then puts installed ones on top
 	sort.Slice(deps, func(i, j int) bool {
-		return deps[i].Name > deps[j].Name &&
-			deps[i].VersionInstalled > deps[j].VersionInstalled
+		return deps[i].Name < deps[j].Name
+	})
+	sort.SliceStable(deps, func(i, j int) bool {
+		if deps[i].VersionInstalled != "" && deps[j].VersionInstalled == "" {
+			return true
+		}
+		return false
 	})
+
 	for _, dep := range deps {
 		res += outputDep(dep)
 	}

Diff for: internal/integrationtest/lib/lib_test.go

@@ -149,32 +149,36 @@ func TestLibDepsOutput(t *testing.T) {
 	require.NoError(t, err)
 
 	// Install some libraries that are dependencies of another library
-	_, _, err = cli.Run("lib", "install", "MKRWAN@1.1.0")
+	_, _, err = cli.Run("lib", "install", "Arduino_DebugUtils@1.3.0")
 	require.NoError(t, err)
-	_, _, err = cli.Run("lib", "install", "[email protected]")
+	_, _, err = cli.Run("lib", "install", "[email protected]")
+	require.NoError(t, err)
+	_, _, err = cli.Run("lib", "install", "[email protected]")
+	require.NoError(t, err)
+	_, _, err = cli.Run("lib", "install", "[email protected]")
 	require.NoError(t, err)
 
 	stdOut, _, err := cli.Run("lib", "deps", "[email protected]", "--no-color")
 	require.NoError(t, err)
 	lines := strings.Split(strings.TrimSpace(string(stdOut)), "\n")
 	require.Len(t, lines, 7)
-	require.Equal(t, "✓ MKRWAN 1.1.0 is already installed.", lines[0])
-	require.Equal(t, "✓ WiFi101 0.16.1 is already installed.", lines[1])
-	require.Equal(t, "✕ Arduino_ConnectionHandler 0.6.6 must be installed.", lines[2])
-	require.Equal(t, "✕ Arduino_DebugUtils 1.3.0 must be installed.", lines[3])
-	require.Equal(t, "✕ MKRGSM 1.5.0 must be installed.", lines[4])
-	require.Equal(t, "✕ MKRNB 1.5.1 must be installed.", lines[5])
-	require.Equal(t, "✕ WiFiNINA 1.8.13 must be installed.", lines[6])
+	require.Equal(t, "✓ Arduino_DebugUtils 1.3.0 is already installed.", lines[0])
+	require.Equal(t, "✓ MKRGSM 1.5.0 is already installed.", lines[1])
+	require.Equal(t, "✓ MKRNB 1.5.1 is already installed.", lines[2])
+	require.Equal(t, "✓ WiFiNINA 1.8.13 is already installed.", lines[3])
+	require.Equal(t, "✕ Arduino_ConnectionHandler 0.6.6 must be installed.", lines[4])
+	require.Equal(t, "✕ MKRWAN 1.1.0 must be installed.", lines[5])
+	require.Equal(t, "✕ WiFi101 0.16.1 must be installed.", lines[6])
 
 	stdOut, _, err = cli.Run("lib", "deps", "[email protected]", "--format", "json")
 	require.NoError(t, err)
 	expectedOutput := `{"dependencies":[
 	{"name":"Arduino_ConnectionHandler","version_required":"0.6.6"},
-	{"name":"Arduino_DebugUtils","version_required":"1.3.0"},
-	{"name":"MKRGSM","version_required":"1.5.0"},
-	{"name":"MKRNB","version_required":"1.5.1"},
-	{"name":"MKRWAN","version_required":"1.1.0","version_installed":"1.1.0"},
-	{"name":"WiFi101","version_required":"0.16.1","version_installed":"0.16.1"},
-	{"name":"WiFiNINA","version_required":"1.8.13"}]}`
+	{"name":"Arduino_DebugUtils","version_required":"1.3.0","version_installed":"1.3.0"},
+	{"name":"MKRGSM","version_required":"1.5.0","version_installed":"1.5.0"},
+	{"name":"MKRNB","version_required":"1.5.1","version_installed":"1.5.1"},
+	{"name":"MKRWAN","version_required":"1.1.0"},
+	{"name":"WiFi101","version_required":"0.16.1"},
+	{"name":"WiFiNINA","version_required":"1.8.13","version_installed":"1.8.13"}]}`
 	require.JSONEq(t, expectedOutput, string(stdOut))
 }