Remove property OTA_STORAGE_TYPE since it's non-relevant for the cloud to know the underlying storage type (#154)

Author: aentinger

Diff for: src/ArduinoIoTCloudTCP.cpp

@@ -81,7 +81,6 @@ ArduinoIoTCloudTCP::ArduinoIoTCloudTCP()
 , _dataTopicIn("")
 , _ota_topic_in{""}
 #if OTA_ENABLED
-, _ota_storage_type{static_cast<int>(OTAStorage::Type::NotAvailable)}
 , _ota_error{static_cast<int>(OTAError::None)}
 #endif /* OTA_ENABLED */
 {
@@ -203,8 +202,6 @@ void ArduinoIoTCloudTCP::printDebugInfo()
 #if OTA_ENABLED
 void ArduinoIoTCloudTCP::setOTAStorage(OTAStorage & ota_storage)
 {
-  _ota_storage_type = static_cast<int>(ota_storage.type());
-  addPropertyReal(_ota_storage_type, "OTA_STORAGE_TYPE", Permission::Read);
   addPropertyReal(_ota_error, "OTA_ERROR", Permission::Read);
   _ota_logic.setOTAStorage(ota_storage);
 }

Diff for: src/ArduinoIoTCloudTCP.h

@@ -129,7 +129,6 @@ class ArduinoIoTCloudTCP: public ArduinoIoTCloudClass
 
 #if OTA_ENABLED
     OTALogic _ota_logic;
-    int _ota_storage_type;
     int _ota_error;
 #endif /* OTA_ENABLED */
 

Diff for: src/utility/ota/OTAStorage.h

@@ -37,14 +37,6 @@ class OTAStorage
   virtual ~OTAStorage() { }
 
 
-  enum class Type : int
-  {
-    NotAvailable = -1,
-    MKRMEM       =  0,
-    MKRGSMFile   =  2,
-  };
-
-  virtual Type   type  () = 0;
   virtual bool   init  () = 0;
   virtual bool   open  (char const * file_name) = 0;
   virtual size_t write (uint8_t const * const buf, size_t const num_bytes) = 0;

Diff for: src/utility/ota/OTAStorage_MKRGSM.h

@@ -40,7 +40,6 @@ class OTAStorage_MKRGSM : public OTAStorage
   virtual ~OTAStorage_MKRGSM() { }
 
 
-  virtual Type   type  () override { return Type::MKRGSMFile; }
   virtual bool   init  () override;
   virtual bool   open  (char const * file_name) override;
   virtual size_t write (uint8_t const * const buf, size_t const num_bytes) override;

Diff for: src/utility/ota/OTAStorage_MKRMEM.h

@@ -41,7 +41,6 @@ class OTAStorage_MKRMEM : public OTAStorage
   virtual ~OTAStorage_MKRMEM() { }
 
 
-  virtual Type   type  () override { return Type::MKRMEM; }
   virtual bool   init  () override;
   virtual bool   open  (char const * file_name) override;
   virtual size_t write (uint8_t const * const buf, size_t const num_bytes) override;