Skip to content

Commit 420f6ef

Browse files
committed
Use buffers in signature checks
1 parent 3f000e9 commit 420f6ef

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

internal/arduino/security/signatures.go

+4-5
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
package security
1717

1818
import (
19+
"bytes"
1920
"embed"
2021
"errors"
2122
"io"
@@ -71,16 +72,14 @@ func VerifySignature(targetPath *paths.Path, signaturePath *paths.Path, arduinoK
7172
if err != nil {
7273
return false, nil, errors.New(i18n.Tr("retrieving Arduino public keys: %s", err))
7374
}
74-
target, err := targetPath.Open()
75+
target, err := targetPath.ReadFile()
7576
if err != nil {
7677
return false, nil, errors.New(i18n.Tr("opening target file: %s", err))
7778
}
78-
defer target.Close()
79-
signature, err := signaturePath.Open()
79+
signature, err := signaturePath.ReadFile()
8080
if err != nil {
8181
return false, nil, errors.New(i18n.Tr("opening signature file: %s", err))
8282
}
83-
defer signature.Close()
84-
signer, err := openpgp.CheckDetachedSignature(keyRing, target, signature, nil)
83+
signer, err := openpgp.CheckDetachedSignature(keyRing, bytes.NewBuffer(target), bytes.NewBuffer(signature), nil)
8584
return (signer != nil && err == nil), signer, err
8685
}

0 commit comments

Comments
 (0)