Skip to content

Commit 3b474e0

Browse files
committed
Removed redundant and useless commands from gRPC interface
1 parent 8e133de commit 3b474e0

File tree

6 files changed

+544
-1388
lines changed

6 files changed

+544
-1388
lines changed

Diff for: commands/daemon/daemon.go

-40
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,7 @@ import (
2828
"github.com/arduino/arduino-cli/commands/core"
2929
"github.com/arduino/arduino-cli/commands/lib"
3030
"github.com/arduino/arduino-cli/commands/monitor"
31-
"github.com/arduino/arduino-cli/commands/outdated"
3231
"github.com/arduino/arduino-cli/commands/sketch"
33-
"github.com/arduino/arduino-cli/commands/upgrade"
3432
"github.com/arduino/arduino-cli/commands/upload"
3533
"github.com/arduino/arduino-cli/i18n"
3634
rpc "github.com/arduino/arduino-cli/rpc/cc/arduino/cli/commands/v1"
@@ -183,44 +181,6 @@ func (s *ArduinoCoreServerImpl) UpdateLibrariesIndex(req *rpc.UpdateLibrariesInd
183181
return stream.Send(&rpc.UpdateLibrariesIndexResponse{})
184182
}
185183

186-
// UpdateCoreLibrariesIndex FIXMEDOC
187-
func (s *ArduinoCoreServerImpl) UpdateCoreLibrariesIndex(req *rpc.UpdateCoreLibrariesIndexRequest, stream rpc.ArduinoCoreService_UpdateCoreLibrariesIndexServer) error {
188-
err := commands.UpdateCoreLibrariesIndex(stream.Context(), req,
189-
func(p *rpc.DownloadProgress) { stream.Send(&rpc.UpdateCoreLibrariesIndexResponse{DownloadProgress: p}) },
190-
func(res *rpc.DownloadResult) { /* ignore */ },
191-
)
192-
if err != nil {
193-
return convertErrorToRPCStatus(err)
194-
}
195-
return stream.Send(&rpc.UpdateCoreLibrariesIndexResponse{})
196-
}
197-
198-
// Outdated FIXMEDOC
199-
func (s *ArduinoCoreServerImpl) Outdated(ctx context.Context, req *rpc.OutdatedRequest) (*rpc.OutdatedResponse, error) {
200-
resp, err := outdated.Outdated(ctx, req)
201-
return resp, convertErrorToRPCStatus(err)
202-
}
203-
204-
// Upgrade FIXMEDOC
205-
func (s *ArduinoCoreServerImpl) Upgrade(req *rpc.UpgradeRequest, stream rpc.ArduinoCoreService_UpgradeServer) error {
206-
err := upgrade.Upgrade(stream.Context(), req,
207-
func(p *rpc.DownloadProgress) {
208-
stream.Send(&rpc.UpgradeResponse{
209-
Progress: p,
210-
})
211-
},
212-
func(p *rpc.TaskProgress) {
213-
stream.Send(&rpc.UpgradeResponse{
214-
TaskProgress: p,
215-
})
216-
},
217-
)
218-
if err != nil {
219-
return convertErrorToRPCStatus(err)
220-
}
221-
return stream.Send(&rpc.UpgradeResponse{})
222-
}
223-
224184
// Create FIXMEDOC
225185
func (s *ArduinoCoreServerImpl) Create(ctx context.Context, req *rpc.CreateRequest) (*rpc.CreateResponse, error) {
226186
var userAgent []string

Diff for: commands/outdated/outdated.go

-48
This file was deleted.

Diff for: commands/upgrade/upgrade.go

-59
This file was deleted.

0 commit comments

Comments
 (0)