Merge pull request #72 from arduino/per1234/fix-checkfunction-crash

per1234 · web-flow · commit 385b1e8b56e0 · 2020-11-26T09:39:27.000-08:00
Fix crash when running LibraryPropertiesNameFieldGTRecommendedLength check function
diff --git a/check/checkfunctions/library.go b/check/checkfunctions/library.go
@@ -144,7 +144,7 @@ func LibraryPropertiesNameFieldGTMaxLength() (result checkresult.Type, output st
 // LibraryPropertiesNameFieldGTRecommendedLength checks if the library.properties "name" value is greater than the recommended length.
 func LibraryPropertiesNameFieldGTRecommendedLength() (result checkresult.Type, output string) {
 	if checkdata.LibraryPropertiesLoadError() != nil {
-		return checkresult.NotRun, checkdata.LibraryProperties().Get("name")
+		return checkresult.NotRun, ""
 	}
 
 	name, ok := checkdata.LibraryProperties().GetOk("name")

Original file line number	Diff line number	Diff line change
`@@ -144,7 +144,7 @@ func LibraryPropertiesNameFieldGTMaxLength() (result checkresult.Type, output st`
`144`	`144`	`// LibraryPropertiesNameFieldGTRecommendedLength checks if the library.properties "name" value is greater than the recommended length.`
`145`	`145`	`func LibraryPropertiesNameFieldGTRecommendedLength() (result checkresult.Type, output string) {`
`146`	`146`	`if checkdata.LibraryPropertiesLoadError() != nil {`
`147`		`- return checkresult.NotRun, checkdata.LibraryProperties().Get("name")`
	`147`	`+ return checkresult.NotRun, ""`
`148`	`148`	`}`
`149`	`149`
`150`	`150`	`name, ok := checkdata.LibraryProperties().GetOk("name")`