Fixed UpdateIndex regression

Author: cmaglie

commands/instances.go

@@ -87,15 +87,13 @@ func Init(ctx context.Context, req *rpc.InitReq) (*rpc.InitResp, error) {
 	if inConfig.DownloadsDir != "" {
 		config.ArduinoDownloadsDir = paths.New(inConfig.DownloadsDir)
 	}
-	urls := []*url.URL{}
 	for _, rawurl := range inConfig.BoardManagerAdditionalUrls {
 		if u, err := url.Parse(rawurl); err == nil {
-			urls = append(urls, u)
+			config.BoardManagerAdditionalUrls = append(config.BoardManagerAdditionalUrls, u)
 		} else {
 			return nil, fmt.Errorf("parsing url %s: %s", rawurl, err)
 		}
 	}
-	config.BoardManagerAdditionalUrls = urls
 
 	pm, lm, reqPltIndex, reqLibIndex, err := createInstance(ctx, config, req.GetLibraryManagerOnly())
 	if err != nil {

daemon/daemon.go

@@ -83,8 +83,10 @@ func (s *ArduinoCoreServerImpl) UpdateIndex(req *rpc.UpdateIndexReq, stream rpc.
 	resp, err := commands.UpdateIndex(stream.Context(), req,
 		func(p *rpc.DownloadProgress) { stream.Send(&rpc.UpdateIndexResp{DownloadProgress: p}) },
 	)
-	stream.Send(resp)
-	return err
+	if err != nil {
+		return err
+	}
+	return stream.Send(resp)
 }
 
 func (s *ArduinoCoreServerImpl) UpdateLibrariesIndex(req *rpc.UpdateLibrariesIndexReq, stream rpc.ArduinoCore_UpdateLibrariesIndexServer) error {