Skip to content

Commit 3657d06

Browse files
ardnewcmaglie
andauthored
Apply suggestions from code review
Co-authored-by: Cristian Maglie <[email protected]>
1 parent 391a80e commit 3657d06

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

Diff for: internal/cli/config/get.go

+3-2
Original file line numberDiff line numberDiff line change
@@ -53,12 +53,13 @@ func runGetCommand(cmd *cobra.Command, args []string) {
5353
for _, toGet := range args {
5454
resp, err := svc.SettingsGetValue(cmd.Context(), &rpc.SettingsGetValueRequest{Key: toGet})
5555
if err != nil {
56-
feedback.Fatal(tr("Cannot get the key %[1]s: %[2]v", toGet, err), feedback.ErrGeneric)
56+
feedback.Fatal(tr("Cannot get the configuration key %[1]s: %[2]v", toGet, err), feedback.ErrGeneric)
5757
}
5858
var result getResult
5959
err = json.Unmarshal([]byte(resp.GetJsonData()), &result.resp)
6060
if err != nil {
61-
feedback.Fatal(tr("Cannot parse JSON for key %[1]s: %[2]v", toGet, err), feedback.ErrGeneric)
61+
// Should never happen...
62+
panic(fmt.Sprintf("Cannot parse JSON for key %[1]s: %[2]v", toGet, err))
6263
}
6364
feedback.PrintResult(result)
6465
}

0 commit comments

Comments
 (0)