Skip to content

Commit 2943ad7

Browse files
cmaglieper1234
andcommitted
Apply suggestions from code review
Co-authored-by: per1234 <[email protected]>
1 parent 77dd4b1 commit 2943ad7

File tree

3 files changed

+9
-10
lines changed

3 files changed

+9
-10
lines changed

Diff for: cli/board/attach.go

+4-4
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ func runAttachCommand(path string, port *arguments.Port, fqbn string) {
6060
Protocol: currentProtocol,
6161
}
6262
}
63-
current := &boradAttachResult{
63+
current := &boardAttachResult{
6464
Port: currentPort,
6565
Fqbn: sk.GetDefaultFQBN(),
6666
}
@@ -99,16 +99,16 @@ func (b *boardAttachPortResult) String() string {
9999
return port
100100
}
101101

102-
type boradAttachResult struct {
102+
type boardAttachResult struct {
103103
Fqbn string `json:"fqbn,omitempty"`
104104
Port *boardAttachPortResult `json:"port,omitempty"`
105105
}
106106

107-
func (b *boradAttachResult) Data() interface{} {
107+
func (b *boardAttachResult) Data() interface{} {
108108
return b
109109
}
110110

111-
func (b *boradAttachResult) String() string {
111+
func (b *boardAttachResult) String() string {
112112
if b.Port == nil && b.Fqbn == "" {
113113
return tr("No default port or FQBN set")
114114
}

Diff for: docs/sketch-project-file.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -121,9 +121,9 @@ and libraries installed in the system.
121121
The sketch project file may be used to set the default value for some command line flags of the Arduino CLI, in
122122
particular:
123123

124-
- The `default_fqbn` directive sets the default value for the `--fqbn` flag
125-
- The `default_port` directive sets the default value for the `--port` flag
126-
- The `default_protocol` directive sets the default value for the `--protocol` flag
124+
- The `default_fqbn` key sets the default value for the `--fqbn` flag
125+
- The `default_port` key sets the default value for the `--port` flag
126+
- The `default_protocol` key sets the default value for the `--protocol` flag
127127

128128
For example:
129129

Diff for: docs/sketch-specification.md

+2-3
Original file line numberDiff line numberDiff line change
@@ -68,9 +68,8 @@ the `data` folder, so any non-code files outside the `data` folder are stripped.
6868

6969
#### `sketch.json`
7070

71-
Arduino Web Editor use a file named `sketch.json`, located in the sketch root folder, to store sketch metadata. This
72-
file is not used by the Arduino CLI or the Arduino IDE, if you're not an Arduino Web Editor user you can safely ignore
73-
it.
71+
Arduino Web Editor uses a file named `sketch.json`, located in the sketch root folder, to store sketch metadata. This
72+
file is not used by Arduino CLI or Arduino IDE, if you're not an Arduino Web Editor user you can safely ignore the file.
7473

7574
The `cpu` key contains the board configuration information. This can be set by selecting a board in the Arduino Web
7675
Editor while the sketch is open.

0 commit comments

Comments
 (0)