Use feedback.Fatal to be consistent with the rest of the codebase

MatteoPologruto · MatteoPologruto · commit 1dc53f71c841 · 2024-12-18T15:15:09.000+01:00
diff --git a/internal/cli/daemon/daemon.go b/internal/cli/daemon/daemon.go
@@ -58,7 +58,7 @@ func NewCommand(srv rpc.ArduinoCoreServiceServer, settings *rpc.Configuration) *
 				})
 				if err != nil {
 					// Should never happen...
-					panic("Failed to set default value for directories.builtin.libraries: " + err.Error())
+					feedback.Fatal(i18n.Tr("Cannot set the configuration key directories.builtin.libraries: %v", err), feedback.ErrGeneric)
 				}
 			}
 
@@ -75,7 +75,7 @@ func NewCommand(srv rpc.ArduinoCoreServiceServer, settings *rpc.Configuration) *
 			})
 			if err != nil {
 				// Should never happen...
-				panic("Failed to set default value for network.user_agent_ext: " + err.Error())
+				feedback.Fatal(i18n.Tr("Cannot set the configuration key network.user_agent_ext: %v", err), feedback.ErrGeneric)
 			}
 		},
 		Run: func(cmd *cobra.Command, args []string) {

Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,7 @@ func NewCommand(srv rpc.ArduinoCoreServiceServer, settings rpc.Configuration) `
`58`	`58`	`})`
`59`	`59`	`if err != nil {`
`60`	`60`	`// Should never happen...`
`61`		`- panic("Failed to set default value for directories.builtin.libraries: " + err.Error())`
	`61`	`+ feedback.Fatal(i18n.Tr("Cannot set the configuration key directories.builtin.libraries: %v", err), feedback.ErrGeneric)`
`62`	`62`	`}`
`63`	`63`	`}`
`64`	`64`
`@@ -75,7 +75,7 @@ func NewCommand(srv rpc.ArduinoCoreServiceServer, settings rpc.Configuration) `
`75`	`75`	`})`
`76`	`76`	`if err != nil {`
`77`	`77`	`// Should never happen...`
`78`		`- panic("Failed to set default value for network.user_agent_ext: " + err.Error())`
	`78`	`+ feedback.Fatal(i18n.Tr("Cannot set the configuration key network.user_agent_ext: %v", err), feedback.ErrGeneric)`
`79`	`79`	`}`
`80`	`80`	`},`
`81`	`81`	`Run: func(cmd *cobra.Command, args []string) {`