Add outdated command to list cores and libs that needs upgrade

Author: silvanocerza

cli/cli.go

@@ -35,6 +35,7 @@ import (
 	"github.com/arduino/arduino-cli/cli/generatedocs"
 	"github.com/arduino/arduino-cli/cli/globals"
 	"github.com/arduino/arduino-cli/cli/lib"
+	"github.com/arduino/arduino-cli/cli/outdated"
 	"github.com/arduino/arduino-cli/cli/output"
 	"github.com/arduino/arduino-cli/cli/sketch"
 	"github.com/arduino/arduino-cli/cli/upload"
@@ -85,6 +86,7 @@ func createCliCommandTree(cmd *cobra.Command) {
 	cmd.AddCommand(daemon.NewCommand())
 	cmd.AddCommand(generatedocs.NewCommand())
 	cmd.AddCommand(lib.NewCommand())
+	cmd.AddCommand(outdated.NewCommand())
 	cmd.AddCommand(sketch.NewCommand())
 	cmd.AddCommand(upload.NewCommand())
 	cmd.AddCommand(debug.NewCommand())

cli/outdated/outdated.go

@@ -0,0 +1,98 @@
+// This file is part of arduino-cli.
+//
+// Copyright 2020 ARDUINO SA (http://www.arduino.cc/)
+//
+// This software is released under the GNU General Public License version 3,
+// which covers the main part of arduino-cli.
+// The terms of this license can be found at:
+// https://www.gnu.org/licenses/gpl-3.0.en.html
+//
+// You can be released from the requirements of the above licenses by purchasing
+// a commercial license. Buying such a license is mandatory if you want to
+// modify or otherwise use the software for commercial activities involving the
+// Arduino software without disclosing the source code of your own applications.
+// To purchase a commercial license, send an email to [email protected].
+
+package outdated
+
+import (
+	"context"
+	"os"
+
+	"github.com/arduino/arduino-cli/cli/errorcodes"
+	"github.com/arduino/arduino-cli/cli/feedback"
+	"github.com/arduino/arduino-cli/cli/instance"
+	"github.com/arduino/arduino-cli/commands/core"
+	"github.com/arduino/arduino-cli/commands/lib"
+	rpc "github.com/arduino/arduino-cli/rpc/commands"
+	"github.com/arduino/arduino-cli/table"
+	"github.com/sirupsen/logrus"
+	"github.com/spf13/cobra"
+)
+
+// NewCommand creates a new `outdated` command
+func NewCommand() *cobra.Command {
+	outdatedCommand := &cobra.Command{
+		Use:   "outdated",
+		Short: "Lists cores and libraries that can be upgraded\n",
+		Long: "This commands shows a list of installed cores and/or libraries\n" +
+			"that can be upgraded. If nothing needs to be updated the output is empty.",
+		Example: "  " + os.Args[0] + " outdated\n",
+		Args:    cobra.NoArgs,
+		Run:     runOutdatedCommand,
+	}
+
+	return outdatedCommand
+}
+
+func runOutdatedCommand(cmd *cobra.Command, args []string) {
+	inst, err := instance.CreateInstance()
+	if err != nil {
+		feedback.Errorf("Error upgrading: %v", err)
+		os.Exit(errorcodes.ErrGeneric)
+	}
+
+	logrus.Info("Executing `arduino outdated`")
+
+	// Gets outdated cores
+	targets, err := core.GetPlatforms(inst.Id, true)
+	if err != nil {
+		feedback.Errorf("Error retrieving core list: %v", err)
+		os.Exit(errorcodes.ErrGeneric)
+	}
+
+	// Gets outdated libraries
+	res, err := lib.LibraryList(context.Background(), &rpc.LibraryListReq{
+		Instance:  inst,
+		All:       true,
+		Updatable: true,
+	})
+	if err != nil {
+		feedback.Errorf("Error retrieving library list: %v", err)
+		os.Exit(errorcodes.ErrGeneric)
+	}
+
+	tab := table.New()
+	tab.SetHeader("Name", "Installed version", "New version")
+
+	// Prints outdated cores
+	if len(targets) > 0 {
+		for _, t := range targets {
+			plat := t.Platform
+			tab.AddRow(plat.Name, t.Version, plat.GetLatestRelease().Version)
+		}
+	}
+
+	// Prints outdated libraries
+	libs := res.GetInstalledLibrary()
+	if len(libs) > 0 {
+		for _, l := range libs {
+			tab.AddRow(l.Library.Name, l.Library.Version, l.Release.Version)
+		}
+	}
+	if len(targets) > 0 || len(libs) > 0 {
+		feedback.Print(tab.Render())
+	}
+
+	logrus.Info("Done")
+}

test/test_outdated.py

@@ -0,0 +1,35 @@
+# This file is part of arduino-cli.
+#
+# Copyright 2020 ARDUINO SA (http://www.arduino.cc/)
+#
+# This software is released under the GNU General Public License version 3,
+# which covers the main part of arduino-cli.
+# The terms of this license can be found at:
+# https://www.gnu.org/licenses/gpl-3.0.en.html
+#
+# You can be released from the requirements of the above licenses by purchasing
+# a commercial license. Buying such a license is mandatory if you want to modify or
+# otherwise use the software for commercial activities involving the Arduino
+# software without disclosing the source code of your own applications. To purchase
+# a commercial license, send an email to [email protected].
+
+
+def test_outdated(run_command):
+    # Updates index for cores and libraries
+    assert run_command("core update-index")
+    assert run_command("lib update-index")
+
+    # Installs an outdated core and library
+    assert run_command("core install arduino:[email protected]")
+    assert run_command("lib install [email protected]")
+
+    # Installs latest version of a core and a library
+    assert run_command("core install arduino:samd")
+    assert run_command("lib install ArduinoJson")
+
+    # Verifies only outdate core and library are returned
+    result = run_command("outdated")
+    assert result.ok
+    lines = result.stdout.splitlines()
+    assert lines[1].startswith("Arduino AVR Boards")
+    assert lines[2].startswith("USBHost")