[breaking] make packages and platform case insensitive pt 4

using the `core.GetPlatform()` approach

Author: umbynos

cli/arguments/reference.go

@@ -18,6 +18,10 @@ package arguments
 import (
 	"fmt"
 	"strings"
+
+	"github.com/arduino/arduino-cli/cli/instance"
+	"github.com/arduino/arduino-cli/commands/core"
+	rpc "github.com/arduino/arduino-cli/rpc/cc/arduino/cli/commands/v1"
 )
 
 // Reference represents a reference item (core or library) passed to the CLI
@@ -80,5 +84,20 @@ func ParseReference(arg string) (*Reference, error) {
 	}
 	ret.Architecture = toks[1]
 
+	// We try to optimize the search and help the user
+	platforms, _ := core.GetPlatforms(&rpc.PlatformListRequest{
+		Instance:      instance.CreateAndInit(),
+		UpdatableOnly: false,
+		All:           true,
+	})
+	for _, platform := range platforms {
+		if strings.EqualFold(platform.GetId(), ret.PackageName+":"+ret.Architecture) {
+			toks = strings.Split(platform.GetId(), ":")
+			ret.PackageName = toks[0]
+			ret.Architecture = toks[1]
+			break // is it ok to stop at the first result?
+		}
+	}
+
 	return ret, nil
 }

cli/arguments/reference_test.go

@@ -19,6 +19,7 @@ import (
 	"testing"
 
 	"github.com/arduino/arduino-cli/cli/arguments"
+	"github.com/arduino/arduino-cli/configuration"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
 )
@@ -45,6 +46,10 @@ var badCores = []struct {
 	{"", nil},
 }
 
+func init() {
+	configuration.Settings = configuration.Init("")
+}
+
 func TestArgsStringify(t *testing.T) {
 	for _, core := range goodCores {
 		require.Equal(t, core.in, core.expected.String())

docs/UPGRADING.md

@@ -4,15 +4,16 @@ Here you can find a list of migration guides to handle breaking changes between
 
 ## Unreleased
 
-### `ParseReferences() function change in `arduino-cli` package
+### `ParseReferences() function change in`arduino-cli` package
 
 The `parseArch` parameter was removed since it was unused and was always true. This means that the architecture gets
 always parsed by the function.
 
-### `ParseReference() function change in `arduino-cli` package
+### `ParseReference() function change in`arduino-cli` package
 
 The `parseArch` parameter was removed since it was unused and was always true. This means that the architecture gets
-always parsed by the function.
+always parsed by the function. Furthermore the function now should also correctly interpret `packager:arch` spelled with
+the wrong casing.
 
 ## 0.20.0