Skip to content

Commit 09c64e6

Browse files
umbynosper1234
andcommitted
Apply suggestions from code review
Co-authored-by: per1234 <[email protected]>
1 parent 5274f2d commit 09c64e6

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

Diff for: .github/workflows/check-certificates.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,8 @@ jobs:
3737
certificate-secret: INSTALLER_CERT_MAC_P12 # Name of the secret that contains the certificate.
3838
password-secret: INSTALLER_CERT_MAC_PASSWORD # Name of the secret that contains the certificate password.
3939
- identifier: Windows signing certificate
40-
certificate-secret: WINDOWS_SIGNING_CERTIFICATE_PFX
41-
password-secret: WINDOWS_SIGNING_CERTIFICATE_PASSWORD
40+
certificate-secret: INSTALLER_CERT_WINDOWS_PASSWORD
41+
password-secret: INSTALLER_CERT_WINDOWS_PFX
4242

4343
steps:
4444
- name: Set certificate path environment variable

Diff for: .github/workflows/publish-go-nightly-task.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ jobs:
5656
id: get-version
5757
env:
5858
NIGHTLY: true
59-
run: echo "::set-output name=version::$(task get-version)"
59+
run: echo "::set-output name=version::$(task general:get-version)"
6060

6161
- name: Upload artifacts
6262
uses: actions/upload-artifact@v3

Diff for: .github/workflows/release-go-task.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ jobs:
6161

6262
- name: Output Version
6363
id: get-version
64-
run: echo "::set-output name=version::$(task get-version)"
64+
run: echo "::set-output name=version::$(task general:get-version)"
6565

6666
- name: Upload artifacts
6767
uses: actions/upload-artifact@v3

Diff for: Taskfile.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -327,7 +327,7 @@ tasks:
327327
cmds:
328328
- poetry run mkdocs serve
329329

330-
get-version:
330+
general:get-version:
331331
desc: Returns the version used in the project
332332
cmds:
333333
- echo {{.VERSION}}

0 commit comments

Comments
 (0)