Migrate TestUpgradeDoesNotTryToUpgradeBundledCoreLibrariesInSketchbook from test_lib.py to lib_test.go

Author: MatteoPologruto

internal/integrationtest/lib/lib_test.go

@@ -1187,3 +1187,37 @@ func TestInstallGitInvalidLibrary(t *testing.T) {
 	require.Contains(t, string(stderr), "library not valid")
 	require.NoDirExists(t, libInstallDir.String())
 }
+
+func TestUpgradeDoesNotTryToUpgradeBundledCoreLibrariesInSketchbook(t *testing.T) {
+	env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)
+	defer env.CleanUp()
+
+	testPlatformName := "platform_with_bundled_library"
+	platformInstallDir := cli.SketchbookDir().Join("hardware", "arduino-beta-dev", testPlatformName)
+	require.NoError(t, platformInstallDir.Parent().MkdirAll())
+
+	// Install platform in Sketchbook hardware dir
+	wd, err := paths.Getwd()
+	require.NoError(t, err)
+	require.NoError(t, wd.Parent().Join("testdata", testPlatformName).CopyDirTo(platformInstallDir))
+
+	_, _, err = cli.Run("update")
+	require.NoError(t, err)
+
+	// Install latest version of library identical to one
+	// bundled with test platform
+	_, _, err = cli.Run("lib", "install", "USBHost")
+	require.NoError(t, err)
+
+	stdout, _, err := cli.Run("lib", "list", "--all", "--format", "json")
+	require.NoError(t, err)
+	requirejson.Len(t, stdout, 2)
+	// Verify both libraries have the same name
+	requirejson.Query(t, stdout, ".[0] | .library | .name", "\"USBHost\"")
+	requirejson.Query(t, stdout, ".[1] | .library | .name", "\"USBHost\"")
+
+	stdout, _, err = cli.Run("lib", "upgrade")
+	require.NoError(t, err)
+	// Empty output means nothing has been updated as expected
+	require.Empty(t, stdout)
+}

test/testdata/platform_with_bundled_library/boards.txt renamed to internal/integrationtest/testdata/platform_with_bundled_library/boards.txt

@@ -206,38 +206,6 @@ def test_install_with_zip_path_multiple_libraries(run_command, downloads_dir, da
     assert ble_install_dir.exists()
 
 
-def test_upgrade_does_not_try_to_upgrade_bundled_core_libraries_in_sketchbook(run_command, data_dir):
-    test_platform_name = "platform_with_bundled_library"
-    platform_install_dir = Path(data_dir, "hardware", "arduino-beta-dev", test_platform_name)
-    platform_install_dir.mkdir(parents=True)
-
-    # Install platform in Sketchbook hardware dir
-    shutil.copytree(
-        Path(__file__).parent / "testdata" / test_platform_name,
-        platform_install_dir,
-        dirs_exist_ok=True,
-    )
-
-    assert run_command(["update"])
-
-    # Install latest version of library identical to one
-    # bundled with test platform
-    assert run_command(["lib", "install", "USBHost"])
-
-    res = run_command(["lib", "list", "--all", "--format", "json"])
-    assert res.ok
-    libs = json.loads(res.stdout)
-    assert len(libs) == 2
-    # Verify both libraries have the same name
-    assert libs[0]["library"]["name"] == "USBHost"
-    assert libs[1]["library"]["name"] == "USBHost"
-
-    res = run_command(["lib", "upgrade"])
-    assert res.ok
-    # Empty output means nothing has been updated as expected
-    assert res.stdout == ""
-
-
 def test_upgrade_does_not_try_to_upgrade_bundled_core_libraries(run_command, data_dir):
     test_platform_name = "platform_with_bundled_library"
     platform_install_dir = Path(data_dir, "packages", "arduino", "hardware", "arch", "4.2.0")