fix CR

Author: alessio-perugini

Diff for: arduino/cores/cores.go

@@ -418,8 +418,5 @@ func (release *PlatformRelease) HasMetadata() bool {
 	}
 
 	installedJSONPath := release.InstallDir.Join("installed.json")
-	if installedJSONPath == nil {
-		return false
-	}
 	return installedJSONPath.Exist()
 }

Diff for: internal/cli/core/upgrade.go

@@ -82,7 +82,7 @@ func Upgrade(inst *rpc.Instance, args []string, skipPostInstall bool) {
 		if response == nil || response.Platform == nil {
 			return
 		}
-		if !response.Platform.Indexed || (response.Platform.MissingMetadata && !response.Platform.Indexed) {
+		if !response.Platform.Indexed {
 			feedback.Warning(tr("missing package index for %s, future updates cannot be guaranteed", response.Platform.Id))
 		}
 	}

Diff for: internal/integrationtest/daemon/daemon_test.go

@@ -19,7 +19,6 @@ import (
 	"context"
 	"fmt"
 	"io"
-	"os"
 	"testing"
 	"time"
 
@@ -457,9 +456,9 @@ func TestDaemonCoreUpgradePlatform(t *testing.T) {
 			grpcInst := cli.Create()
 			updateIndexAndInstallPlatform(cli, grpcInst, "3.1.0")
 
-			// remove installed.json{
+			// remove installed.json
 			x := env.RootDir().Join("A/packages/esp8266/hardware/esp8266/3.1.0/installed.json")
-			require.NoError(t, os.Remove(x.String()))
+			require.NoError(t, x.Remove())
 
 			plUpgrade, err := grpcInst.PlatformUpgrade(context.Background(), "esp8266", "esp8266", true)
 			require.NoError(t, err)
@@ -507,7 +506,7 @@ func TestDaemonCoreUpgradePlatform(t *testing.T) {
 				refreshInstance(t, grpcInst)
 
 				x := env.RootDir().Join("A/packages/esp8266/hardware/esp8266/3.1.0/installed.json")
-				require.NoError(t, os.Remove(x.String()))
+				require.NoError(t, x.Remove())
 			}
 
 			plUpgrade, err := grpcInst.PlatformUpgrade(context.Background(), "esp8266", "esp8266", true)

Diff for: rpc/cc/arduino/cli/commands/v1/common.pb.go

@@ -104,7 +104,9 @@ message Platform {
   HelpResources help = 12;
   // If true the platform is indexed
   bool indexed = 13;
-  // This field is true when the platform is installed with the Arduino IDE 1.8
+  // This field is true when the platform is installed with the Arduino IDE 1.8.
+  // If the platform is also not indexed it may fail to work correctly in some circumstances,
+  // and it may need to be re-installed.
   bool missing_metadata = 14;
 }
 

Diff for: rpc/cc/arduino/cli/commands/v1/common.proto

@@ -97,7 +97,7 @@ message PlatformUpgradeResponse {
   DownloadProgress progress = 1;
   // Description of the current stage of the upgrade.
   TaskProgress task_progress = 2;
-  // Platform to be upgraded.
+  // The upgraded platform.
   Platform platform = 3;
 }