Skip to content

Commit 032be41

Browse files
Retrieve programmer's information from the profile if the flag is not used
1 parent 946a445 commit 032be41

File tree

4 files changed

+23
-3
lines changed

4 files changed

+23
-3
lines changed

Diff for: commands/upload/upload.go

+6-1
Original file line numberDiff line numberDiff line change
@@ -146,14 +146,19 @@ func Upload(ctx context.Context, req *rpc.UploadRequest, outStream io.Writer, er
146146
fqbn = pme.GetProfile().FQBN
147147
}
148148

149+
programmer := req.GetProgrammer()
150+
if programmer == "" && pme.GetProfile() != nil {
151+
programmer = pme.GetProfile().Programmer
152+
}
153+
149154
updatedPort, err := runProgramAction(
150155
pme,
151156
sk,
152157
req.GetImportFile(),
153158
req.GetImportDir(),
154159
fqbn,
155160
req.GetPort(),
156-
req.GetProgrammer(),
161+
programmer,
157162
req.GetVerbose(),
158163
req.GetVerify(),
159164
false, // burnBootloader

Diff for: internal/cli/arguments/programmer.go

+5
Original file line numberDiff line numberDiff line change
@@ -56,3 +56,8 @@ func (p *Programmer) String(inst *commands.Instance, fqbn string) string {
5656
}
5757
return details.GetDefaultProgrammerId()
5858
}
59+
60+
// GetProgrammer returns the programmer specified by the user
61+
func (p *Programmer) GetProgrammer() string {
62+
return p.programmer
63+
}

Diff for: internal/cli/compile/compile.go

+6-1
Original file line numberDiff line numberDiff line change
@@ -268,6 +268,11 @@ func runCompileCommand(cmd *cobra.Command, args []string) {
268268
}
269269
}
270270

271+
prog := profile.GetProgrammer()
272+
if prog == "" || programmer.GetProgrammer() != "" {
273+
prog = programmer.String(inst, fqbn)
274+
}
275+
271276
uploadRequest := &rpc.UploadRequest{
272277
Instance: inst,
273278
Fqbn: fqbn,
@@ -276,7 +281,7 @@ func runCompileCommand(cmd *cobra.Command, args []string) {
276281
Verbose: verbose,
277282
Verify: verify,
278283
ImportDir: buildPath,
279-
Programmer: programmer.String(inst, fqbn),
284+
Programmer: prog,
280285
UserFields: fields,
281286
}
282287

Diff for: internal/cli/upload/upload.go

+6-1
Original file line numberDiff line numberDiff line change
@@ -176,6 +176,11 @@ func runUploadCommand(args []string, uploadFieldsArgs map[string]string) {
176176
path = sketchPath.String()
177177
}
178178

179+
prog := profile.GetProgrammer()
180+
if prog == "" || programmer.GetProgrammer() != "" {
181+
prog = programmer.String(inst, fqbn)
182+
}
183+
179184
stdOut, stdErr, stdIOResult := feedback.OutputStreams()
180185
req := &rpc.UploadRequest{
181186
Instance: inst,
@@ -186,7 +191,7 @@ func runUploadCommand(args []string, uploadFieldsArgs map[string]string) {
186191
Verify: verify,
187192
ImportFile: importFile,
188193
ImportDir: importDir,
189-
Programmer: programmer.String(inst, fqbn),
194+
Programmer: prog,
190195
DryRun: dryRun,
191196
UserFields: fields,
192197
}

0 commit comments

Comments
 (0)