Skip to content

Commit 0167c2d

Browse files
cmaglieper1234
andauthored
Apply suggestions from code review
Co-authored-by: per1234 <[email protected]>
1 parent 82e47d3 commit 0167c2d

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed

Diff for: Taskfile.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ tasks:
9090
9191
# Source: https://github.com/arduino/tooling-project-assets/blob/main/workflow-templates/assets/test-go-task/Taskfile.yml
9292
go:test:
93-
desc: Run unit tests and part of the integration tests
93+
desc: Run unit tests and the Go-based integration tests
9494
deps:
9595
- task: go:build
9696
dir: '{{default "./" .GO_MODULE_PATH}}'

Diff for: internal/integrationtest/core/core_test.go

-2
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,6 @@ func TestCoreSearch(t *testing.T) {
6262
out, _, err = cli.Run("core", "search", "test_core", "--all", "--format", "json", "--additional-urls="+url.String())
6363
require.NoError(t, err)
6464
requirejson.Len(t, out, 2)
65-
// requirejson.Len(t, out, 3) // Test failure
6665

6766
checkPlatformIsInJSONOutput := func(stdout []byte, id, version string) {
6867
jqquery := fmt.Sprintf(`[{id:"%s", latest:"%s"}]`, id, version)
@@ -74,7 +73,6 @@ func TestCoreSearch(t *testing.T) {
7473
require.NoError(t, err)
7574
checkPlatformIsInJSONOutput(out, "Retrokits-RK002:arm", "1.0.5")
7675
checkPlatformIsInJSONOutput(out, "Retrokits-RK002:arm", "1.0.6")
77-
//checkPlatformIsInJSONOutput(out, "Retrokits-RK002:arm", "1.0.9") // Test failure
7876

7977
// Search using Retrokit Package Maintainer
8078
out, _, err = cli.Run("core", "search", "Retrokits-RK002", "--all", "--additional-urls="+url.String(), "--format", "json")

0 commit comments

Comments
 (0)