Skip to content

Commit 01611d7

Browse files
committed
Added board config detection in 'commands.identify' function
1 parent 6cb04f7 commit 01611d7

File tree

1 file changed

+8
-1
lines changed

1 file changed

+8
-1
lines changed

Diff for: commands/board/list.go

+8-1
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ import (
2626
"time"
2727

2828
"github.com/arduino/arduino-cli/arduino"
29+
"github.com/arduino/arduino-cli/arduino/cores"
2930
"github.com/arduino/arduino-cli/arduino/cores/packagemanager"
3031
"github.com/arduino/arduino-cli/arduino/discovery"
3132
"github.com/arduino/arduino-cli/arduino/httpclient"
@@ -123,13 +124,19 @@ func identify(pm *packagemanager.PackageManager, port *discovery.Port) ([]*rpc.B
123124
// first query installed cores through the Package Manager
124125
logrus.Debug("Querying installed cores for board identification...")
125126
for _, board := range pm.IdentifyBoard(port.Properties) {
127+
fqbn, err := cores.ParseFQBN(board.FQBN())
128+
if err != nil {
129+
return nil, &arduino.InvalidFQBNError{Cause: err}
130+
}
131+
fqbn.Configs = board.IdentifyBoardConfiguration(port.Properties)
132+
126133
// We need the Platform maintaner for sorting so we set it here
127134
platform := &rpc.Platform{
128135
Maintainer: board.PlatformRelease.Platform.Package.Maintainer,
129136
}
130137
boards = append(boards, &rpc.BoardListItem{
131138
Name: board.Name(),
132-
Fqbn: board.FQBN(),
139+
Fqbn: fqbn.String(),
133140
Platform: platform,
134141
})
135142
}

0 commit comments

Comments
 (0)