convert intermediate file EOLs to pure \n format #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks fine to me |
otherwise all processing on ino file will likely fail solves arduino#114
facchinm
force-pushed
the
canonical_eol
branch
from
33b1e93 to
7ff1de1
Compare
|
@cmaglie would you have a look at it too? thanks! |
|
LGTM 👍 I'd just add a comment in |
|
Great! Could someone merge and launch a build? So this agìfternoon we can test it on Create and release it tomorrow. Thanks! |
matteosuppo
added a commit
that referenced
this pull request
Feb 10, 2016
convert intermediate file EOLs to pure \n format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
otherwise all processing on ino file will likely fail
solves #114
@matteosuppo @cmaglie @matthijskooijman