Skip to content

Assembler files in sketches (presumably) won't work #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
matthijskooijman opened this issue Nov 27, 2015 · 0 comments
Closed

Assembler files in sketches (presumably) won't work #74

matthijskooijman opened this issue Nov 27, 2015 · 0 comments
Assignees
Milestone

Comments

@matthijskooijman
Copy link
Collaborator

From reviewing the code (in response to a question on IRC) I believe that assembler files .S in sketches will not currently work. It seems there is code to support .S files using recipes, but .S files are not listed as files to copy into the build dir here: https://github.com/arduino/arduino-builder/blob/master/src/arduino.cc/builder/builder.go#L44-L45

I haven't actually tested this, but I believe things are broken and a fix should be a matter of adding .S files to that list.

At the same time, it might be useful to also add .inc files, since it seems those are sometimes used as assembly include files.

For some example assembler files to use for testing, see https://github.com/digistump/DigisparkArduinoIntegration/tree/master/libraries/DigisparkKeyboard

@matthijskooijman matthijskooijman changed the title Assembler files in sketches won't work Assembler files in sketches (presumably) won't work Nov 27, 2015
@ffissore ffissore added this to the 1.3.1 milestone Nov 30, 2015
@ffissore ffissore self-assigned this Nov 30, 2015
@ffissore ffissore added the bug label Nov 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants