-
-
Notifications
You must be signed in to change notification settings - Fork 114
Arduino-Builder not reloading .h files correct #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
If you compare those 3 commands, they are all the same:
|
And now the detailed output in the same order as above:
|
Those files reside in Also, please @NicoHood, I'm super happy about your issues, they are helping me solving a number of issues, but please post your dumps on http://gist.github.com/. My mouse scroll wheel is burning! |
Whoops, yes I forgot about gist.github. I edited the files inside linux/work which ARE used bz the IDE. Its not a rebuilding issue. I want to modify the core at runtime for debugging (as always). Or do you want to say I need to rebuild the ide for every core modification? That sounds weird. If I had edited the wrong files no error would occur because the wrong files dont cause any changes. I dont know if you missunderstood, but we are not talking about recompiling the IDE, its just opening the ide and modifying the core at runtime. This also happens with mc HID-Project library. Not sure if this is caused by the .a linkage, but could be. I dont have a testcase for the HID Project library but for the core as linked above. |
I already got that this is not about rebuilding the IDE: I wanted you to double check you were modifying the right files. Can you please provide a smaller test case? Something that doesn't rely on your repo which is under development? |
The repo is not under development, i stopped because of that. I also linked the commit just for this testcase. I just edited the core files as usual. Other testcase: This causes the same issue. Tested with and without .a linkage. The .h file change is not recognized as update and the depending .cpp files are not recompiled. I guess you can do this with any library with a .h and .cpp file. If the .cpp file is changed the error(.h file change) will be recognized. |
I think I found the root cause, which is a poor implementation of "already compiled" check. I'm working on it |
Seems to be fixed now. thanks! |
👍 |
I guess this is related to the builder now. I've noticed this before as well, but now I have a testcase.
See this commit:
NicoHood/Arduino@ed03da4
First compilation:
Then you comment out those two lines (60 + 61):
NicoHood/Arduino@ed03da4#diff-80f8fa652cb7f1f5631287edd3fa82ddR60
Then you remove the comments again and it will still compile. huh?
Note that the last recompile happens instant.
The text was updated successfully, but these errors were encountered: