Skip to content

go packages deprecated? #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
CatherineH opened this issue May 13, 2016 · 1 comment
Closed

go packages deprecated? #147

CatherineH opened this issue May 13, 2016 · 1 comment
Labels
conclusion: resolved Issue was resolved topic: infrastructure Related to project infrastructure
Milestone
1.3.19

Comments

@CatherineH
Copy link
Contributor

The go packages x/tools/cmd/vet and x/codereview/patch seem to have been removed:

https://godoc.org/golang.org/x/tools/cmd/vet
https://godoc.org/golang.org/x/codereview/patch

Is there a workaround that doesn't use these packages?
@cmaglie
Copy link
Member

cmaglie commented May 17, 2016

x/codereview/patch has been used to apply patches dropped in test/downloaded_stuff_patches folder. Since there are no patches at the moment I disabled it, and removed the dependency.

If we will ever need .patch files in the future we'll find another implementation in that moment.

golang.org/x/tools/cmd/vet is no more a dependency since it's bundled in latest versions of go.

@cmaglie cmaglie modified the milestone: 1.3.19 May 17, 2016
@per1234 per1234 added conclusion: resolved Issue was resolved topic: infrastructure Related to project infrastructure labels Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
conclusion: resolved Issue was resolved topic: infrastructure Related to project infrastructure
Projects
None yet
Milestone
1.3.19
Development

No branches or pull requests
3 participants
@cmaglie @CatherineH @per1234