Skip to content

Remove IncludesFinderWithGCC #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
matthijskooijman opened this issue Feb 3, 2016 · 1 comment
Closed

Remove IncludesFinderWithGCC #108

matthijskooijman opened this issue Feb 3, 2016 · 1 comment
Milestone
1.3.19

Comments

@matthijskooijman
Copy link
Collaborator

AFAICS the IncludesFinderWithGCC type, as well as the recipe.preproc.includes in platform.txt that was only used by this type, can be removed. When the include collection switched from parsing dependency files to parsing gcc errors, this code became unused but was left around. To prevent confusion, it seems good to remove it now.
@matthijskooijman
Copy link
Collaborator Author

This also applies to https://github.com/arduino/Arduino/blob/master/hardware/arduino/avr/platform.txt#L85-L86

@cmaglie cmaglie added this to the 1.3.19 milestone May 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3.19
Development

No branches or pull requests
2 participants
@matthijskooijman @cmaglie