Avoid using whole ctags_target_for_gcc_minus_e for prototype generation

Ctags is FULL of bugs on c++ parsing (and c++ syntax is a nightmare), sketches are usually way more simple (and easier to debug).
Using a simplified version of the ctags_target_for_gcc_minus_e file which only contains preprocessor directives and the sketch lines helps avoiding most ctags subtle bugs.

Signed-off-by: Martino Facchin <[email protected]>

Author: facchinm

src/arduino.cc/builder/ctags_target_file_saver.go

@@ -34,6 +34,8 @@ import (
 	"arduino.cc/builder/types"
 	"arduino.cc/builder/utils"
 	"path/filepath"
+	"strconv"
+	"strings"
 )
 
 type CTagsTargetFileSaver struct {
@@ -50,6 +52,12 @@ func (s *CTagsTargetFileSaver) Run(ctx *types.Context) error {
 		return i18n.WrapError(err)
 	}
 
+	// drop every line which is not part of user sketch or a define/ifdef/endif/etc
+	var searchSlice []string
+	searchSlice = append(searchSlice, filepath.Dir(context[constants.CTX_SKETCH_LOCATION].(string)))
+	searchSlice = append(searchSlice, filepath.Dir(context[constants.CTX_SKETCH_BUILD_PATH].(string)))
+	source = saveLinesContainingDirectivesAndSketch(source, searchSlice)
+
 	ctagsTargetFilePath := filepath.Join(preprocPath, s.TargetFileName)
 	err = utils.WriteFile(ctagsTargetFilePath, source)
 	if err != nil {
@@ -60,3 +68,52 @@ func (s *CTagsTargetFileSaver) Run(ctx *types.Context) error {
 
 	return nil
 }
+
+func saveLinesContainingDirectivesAndSketch(src string, tofind []string) string {
+	lines := strings.Split(src, "\n")
+
+	saveLine := false
+	minimizedString := ""
+
+	for _, line := range lines {
+		if saveLine || startsWithHashtag(line) {
+			minimizedString += line + "\n"
+		}
+		if containsAny(line, tofind) && isPreprocessorLineMarker(line) {
+			saveLine = true
+		}
+		if saveLine && !containsAny(line, tofind) && isPreprocessorLineMarker(line) {
+			saveLine = false
+		}
+	}
+	return minimizedString
+}
+
+func containsAny(src string, tofind []string) bool {
+	for _, str := range tofind {
+		if strings.Contains(src, str) {
+			return true
+		}
+	}
+	return false
+}
+
+func startsWithHashtag(src string) bool {
+	trimmedStr := strings.TrimSpace(src)
+	if len(trimmedStr) > 0 && trimmedStr[0] == '#' {
+		return true
+	}
+	return false
+}
+
+func isPreprocessorLineMarker(src string) bool {
+	trimmedStr := strings.TrimSpace(src)
+	splittedStr := strings.Split(trimmedStr, " ")
+	if len(splittedStr) > 2 && splittedStr[0] == "#" {
+		_, err := strconv.Atoi(splittedStr[1])
+		if err == nil {
+			return true
+		}
+	}
+	return false
+}