Skip to content

Commit aee32ff

Browse files
author
Federico Fissore
committed
core builder: variant files were compiled but not linked. Fixes #14
Signed-off-by: Federico Fissore <[email protected]>
1 parent 7630735 commit aee32ff

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

Diff for: src/arduino.cc/builder/phases/core_builder.go

+5-3
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,6 @@ func (s *CoreBuilder) Run(context map[string]interface{}) error {
6262
}
6363

6464
func compileCore(buildPath string, buildProperties map[string]string, verbose bool, warningsLevel string, logger i18n.Logger) (string, error) {
65-
var objectFiles []string
6665
coreFolder := buildProperties[constants.BUILD_PROPERTIES_BUILD_CORE_PATH]
6766
variantFolder := buildProperties[constants.BUILD_PROPERTIES_BUILD_VARIANT_PATH]
6867

@@ -75,8 +74,9 @@ func compileCore(buildPath string, buildProperties map[string]string, verbose bo
7574

7675
var err error
7776

77+
var variantObjectFiles []string
7878
if variantFolder != constants.EMPTY_STRING {
79-
objectFiles, err = builder_utils.CompileFiles(objectFiles, variantFolder, true, buildPath, buildProperties, includes, verbose, warningsLevel, logger)
79+
variantObjectFiles, err = builder_utils.CompileFiles(variantObjectFiles, variantFolder, true, buildPath, buildProperties, includes, verbose, warningsLevel, logger)
8080
if err != nil {
8181
return "", utils.WrapError(err)
8282
}
@@ -87,7 +87,9 @@ func compileCore(buildPath string, buildProperties map[string]string, verbose bo
8787
return "", utils.WrapError(err)
8888
}
8989

90-
archiveFile, err := builder_utils.ArchiveCompiledFiles(buildPath, "core.a", coreObjectFiles, buildProperties, verbose, logger)
90+
objectFiles := append(coreObjectFiles, variantObjectFiles...)
91+
92+
archiveFile, err := builder_utils.ArchiveCompiledFiles(buildPath, "core.a", objectFiles, buildProperties, verbose, logger)
9193
if err != nil {
9294
return "", utils.WrapError(err)
9395
}

0 commit comments

Comments
 (0)