Recursive compile of subfolders in sketch is no more allowed

See #89

Signed-off-by: Cristian Maglie <[email protected]>

Author: cmaglie

Diff for: src/arduino.cc/builder/test/builder_test.go

@@ -30,14 +30,15 @@
 package test
 
 import (
-	"arduino.cc/builder"
-	"arduino.cc/builder/constants"
-	"arduino.cc/builder/types"
-	"github.com/stretchr/testify/require"
 	"os"
 	"os/exec"
 	"path/filepath"
 	"testing"
+
+	"arduino.cc/builder"
+	"arduino.cc/builder/constants"
+	"arduino.cc/builder/types"
+	"github.com/stretchr/testify/require"
 )
 
 func TestBuilderEmptySketch(t *testing.T) {
@@ -324,26 +325,28 @@ func TestBuilderSketchWithOldLib(t *testing.T) {
 	NoError(t, err)
 }
 
-func TestBuilderSketchWithSubfolders(t *testing.T) {
-	DownloadCoresAndToolsAndLibraries(t)
-
-	ctx := &types.Context{
-		HardwareFolders:         []string{filepath.Join("..", "hardware"), "hardware", "downloaded_hardware"},
-		ToolsFolders:            []string{"downloaded_tools"},
-		BuiltInLibrariesFolders: []string{"downloaded_libraries"},
-		OtherLibrariesFolders:   []string{"libraries"},
-		SketchLocation:          filepath.Join("sketch_with_subfolders", "sketch_with_subfolders.ino"),
-		FQBN:                    "arduino:avr:uno",
-		ArduinoAPIVersion:       "10600",
-	}
-
-	buildPath := SetupBuildPath(t, ctx)
-	defer os.RemoveAll(buildPath)
-
-	command := builder.Builder{}
-	err := command.Run(ctx)
-	NoError(t, err)
-}
+// Recursive compile of subfolder is no longer supported.
+// See: https://github.com/arduino/arduino-builder/issues/89
+//func TestBuilderSketchWithSubfolders(t *testing.T) {
+//	DownloadCoresAndToolsAndLibraries(t)
+//
+//	ctx := &types.Context{
+//		HardwareFolders:         []string{filepath.Join("..", "hardware"), "hardware", "downloaded_hardware"},
+//		ToolsFolders:            []string{"downloaded_tools"},
+//		BuiltInLibrariesFolders: []string{"downloaded_libraries"},
+//		OtherLibrariesFolders:   []string{"libraries"},
+//		SketchLocation:          filepath.Join("sketch_with_subfolders", "sketch_with_subfolders.ino"),
+//		FQBN:                    "arduino:avr:uno",
+//		ArduinoAPIVersion:       "10600",
+//	}
+//
+//	buildPath := SetupBuildPath(t, ctx)
+//	defer os.RemoveAll(buildPath)
+//
+//	command := builder.Builder{}
+//	err := command.Run(ctx)
+//	NoError(t, err)
+//}
 
 func TestBuilderSketchBuildPathContainsUnusedPreviouslyCompiledLibrary(t *testing.T) {
 	DownloadCoresAndToolsAndLibraries(t)

Diff for: src/arduino.cc/builder/test/try_build_of_problematic_sketch_test.go

@@ -96,9 +96,11 @@ func TestTryBuild014(t *testing.T) {
 	tryBuild(t, "sketch_with_backup_files", "sketch.ino")
 }
 
-func TestTryBuild015(t *testing.T) {
-	tryBuild(t, "sketch_with_subfolders")
-}
+// Recursive compile of subfolder is no longer supported.
+// See: https://github.com/arduino/arduino-builder/issues/89
+//func TestTryBuild015(t *testing.T) {
+//	tryBuild(t, "sketch_with_subfolders")
+//}
 
 // This is a sketch that fails to build on purpose
 //func TestTryBuild016(t *testing.T) {