Skip to content

Commit 377bebe

Browse files
committed
IncludeFolders now in Context
Signed-off-by: Cristian Maglie <[email protected]>
1 parent 310f2e2 commit 377bebe

File tree

7 files changed

+7
-15
lines changed

7 files changed

+7
-15
lines changed

src/arduino.cc/builder/constants/constants.go

-1
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,6 @@ const CTX_GCC_MINUS_E_SOURCE = "gccMinusESource"
8181
const CTX_GCC_MINUS_M_OUTPUT = "gccMinusMOutput"
8282
const CTX_HARDWARE = "hardware"
8383
const CTX_HARDWARE_REWRITE_RESULTS = "hardwareRewriteResults"
84-
const CTX_INCLUDE_FOLDERS = "includeFolders"
8584
const CTX_INCLUDE_SECTION = "includeSection"
8685
const CTX_INCLUDES_JUST_FOUND = "includesJustFound"
8786
const CTX_LINE_OFFSET = "lineOffset"

src/arduino.cc/builder/gcc_preproc_runner.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ func prepareGCCPreprocRecipeProperties(context map[string]interface{}, ctx *type
112112
properties[constants.BUILD_PROPERTIES_SOURCE_FILE] = sourceFilePath
113113
properties[constants.BUILD_PROPERTIES_PREPROCESSED_FILE_PATH] = targetFilePath
114114

115-
includes := context[constants.CTX_INCLUDE_FOLDERS].([]string)
115+
includes := ctx.IncludeFolders
116116
includes = utils.Map(includes, utils.WrapWithHyphenI)
117117
properties[constants.BUILD_PROPERTIES_INCLUDES] = strings.Join(includes, constants.SPACE)
118118
builder_utils.RemoveHyphenMDDFlagFromGCCCommandLine(properties)

src/arduino.cc/builder/includes_finder_with_gcc.go

+2-6
Original file line numberDiff line numberDiff line change
@@ -47,12 +47,8 @@ func (s *IncludesFinderWithGCC) Run(context map[string]interface{}, ctx *types.C
4747
verbose := ctx.Verbose
4848
logger := ctx.GetLogger()
4949

50-
includesParams := constants.EMPTY_STRING
51-
if utils.MapHas(context, constants.CTX_INCLUDE_FOLDERS) {
52-
includes := context[constants.CTX_INCLUDE_FOLDERS].([]string)
53-
includes = utils.Map(includes, utils.WrapWithHyphenI)
54-
includesParams = strings.Join(includes, " ")
55-
}
50+
includes := utils.Map(ctx.IncludeFolders, utils.WrapWithHyphenI)
51+
includesParams := strings.Join(includes, " ")
5652

5753
properties := buildProperties.Clone()
5854
properties[constants.BUILD_PROPERTIES_SOURCE_FILE] = s.SourceFile

src/arduino.cc/builder/includes_to_include_folders.go

+1-5
Original file line numberDiff line numberDiff line change
@@ -68,11 +68,7 @@ func (s *IncludesToIncludeFolders) Run(context map[string]interface{}, ctx *type
6868
}
6969

7070
ctx.ImportedLibraries = importedLibraries
71-
72-
buildProperties := ctx.BuildProperties
73-
verbose := ctx.Verbose
74-
includeFolders := resolveIncludeFolders(newlyImportedLibraries, buildProperties, verbose)
75-
context[constants.CTX_INCLUDE_FOLDERS] = includeFolders
71+
ctx.IncludeFolders = resolveIncludeFolders(newlyImportedLibraries, ctx.BuildProperties, ctx.Verbose)
7672

7773
return nil
7874
}

src/arduino.cc/builder/phases/libraries_builder.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ type LibrariesBuilder struct{}
4545
func (s *LibrariesBuilder) Run(context map[string]interface{}, ctx *types.Context) error {
4646
librariesBuildPath := ctx.LibrariesBuildPath
4747
buildProperties := ctx.BuildProperties
48-
includes := context[constants.CTX_INCLUDE_FOLDERS].([]string)
48+
includes := ctx.IncludeFolders
4949
includes = utils.Map(includes, utils.WrapWithHyphenI)
5050
libraries := ctx.ImportedLibraries
5151
verbose := ctx.Verbose

src/arduino.cc/builder/phases/sketch_builder.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ type SketchBuilder struct{}
4242
func (s *SketchBuilder) Run(context map[string]interface{}, ctx *types.Context) error {
4343
sketchBuildPath := ctx.SketchBuildPath
4444
buildProperties := ctx.BuildProperties
45-
includes := context[constants.CTX_INCLUDE_FOLDERS].([]string)
45+
includes := ctx.IncludeFolders
4646
includes = utils.Map(includes, utils.WrapWithHyphenI)
4747
verbose := ctx.Verbose
4848
warningsLevel := ctx.WarningsLevel

src/arduino.cc/builder/types/context.go

+1
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ type Context struct {
4343
HeaderToLibraries map[string][]*Library
4444
ImportedLibraries []*Library
4545
LibrariesResolutionResults map[string]LibraryResolutionResult
46+
IncludeFolders []string
4647

4748
// C++ Parsing
4849
CTagsOutput string

0 commit comments

Comments
 (0)