Moved "gcc -M" output in Context

It seems legacy, shall we remove it? eventually may turn out to be
useful in the future?

Signed-off-by: Cristian Maglie <[email protected]>

Author: cmaglie

Diff for: src/arduino.cc/builder/constants/constants.go

@@ -76,7 +76,6 @@ const CTAGS = "ctags"
 const CTX_ARCHIVE_FILE_PATH_CORE = "archiveFileCore"
 const CTX_BUILD_CORE = "buildCore"
 const CTX_FILE_PATH_TO_READ = "filePathToRead"
-const CTX_GCC_MINUS_M_OUTPUT = "gccMinusMOutput"
 const CTX_HARDWARE_REWRITE_RESULTS = "hardwareRewriteResults"
 const CTX_INCLUDE_SECTION = "includeSection"
 const CTX_INCLUDES_JUST_FOUND = "includesJustFound"

Diff for: src/arduino.cc/builder/gcc_minus_m_output_parser.go

@@ -39,7 +39,7 @@ import (
 type GCCMinusMOutputParser struct{}
 
 func (s *GCCMinusMOutputParser) Run(context map[string]interface{}, ctx *types.Context) error {
-	output := context[constants.CTX_GCC_MINUS_M_OUTPUT].(string)
+	output := ctx.OutputGccMinusM
 
 	rows := strings.Split(output, "\n")
 	includes := make([]string, 0)

Diff for: src/arduino.cc/builder/includes_finder_with_gcc.go

@@ -65,7 +65,7 @@ func (s *IncludesFinderWithGCC) Run(context map[string]interface{}, ctx *types.C
 		return i18n.WrapError(err)
 	}
 
-	context[constants.CTX_GCC_MINUS_M_OUTPUT] = string(output)
+	ctx.OutputGccMinusM = string(output)
 
 	return nil
 }

Diff for: src/arduino.cc/builder/test/gcc_minus_m_output_parser_test.go

@@ -31,7 +31,6 @@ package test
 
 import (
 	"arduino.cc/builder"
-	"arduino.cc/builder/constants"
 	"arduino.cc/builder/types"
 	"github.com/stretchr/testify/require"
 	"testing"
@@ -49,7 +48,7 @@ func TestGCCMinusMOutputParser(t *testing.T) {
 		"\n" +
 		"Bridge.h:\n"
 
-	context[constants.CTX_GCC_MINUS_M_OUTPUT] = output
+	ctx.OutputGccMinusM = output
 
 	parser := builder.GCCMinusMOutputParser{}
 	err := parser.Run(context, ctx)
@@ -68,7 +67,7 @@ func TestGCCMinusMOutputParserEmptyOutput(t *testing.T) {
 
 	output := "sketch.ino.o: /tmp/test699709208/sketch/sketch.ino.cpp"
 
-	context[constants.CTX_GCC_MINUS_M_OUTPUT] = output
+	ctx.OutputGccMinusM = output
 
 	parser := builder.GCCMinusMOutputParser{}
 	err := parser.Run(context, ctx)
@@ -93,7 +92,7 @@ func TestGCCMinusMOutputParserFirstLineOnMultipleLines(t *testing.T) {
 		"\n" +
 		"Bridge.h:\n"
 
-	context[constants.CTX_GCC_MINUS_M_OUTPUT] = output
+	ctx.OutputGccMinusM = output
 
 	parser := builder.GCCMinusMOutputParser{}
 	err := parser.Run(context, ctx)

Diff for: src/arduino.cc/builder/types/context.go

@@ -51,6 +51,7 @@ type Context struct {
 	ImportedLibraries          []*Library
 	LibrariesResolutionResults map[string]LibraryResolutionResult
 	IncludeFolders             []string
+	OutputGccMinusM            string
 
 	// C++ Parsing
 	CTagsOutput                 string