From 6f93f9bfeff454d2dd0f1c1247b52ff7df241f97 Mon Sep 17 00:00:00 2001 From: per1234 Date: Mon, 22 Feb 2021 15:20:09 -0800 Subject: [PATCH] Pin Ace* libraries at last compatible version in CI workflow Due to incompatibilities introduced during the initial ArduinoCore-API incorporation, the author of the AceTime and AceCommon libraries has added an #error directive that is triggered when the libraries are compiled by any version of arduino;samd that uses ArduinoCore-API: - https://github.com/bxparks/AceTime/blob/v1.6/src/AceTime.h#L25-L26 - https://github.com/bxparks/AceCommon/blob/v1.4.3/src/AceCommon.h#L44-L45 Ironically, compilation of the AceTime examples was added specifically to avoid any future breakage of compatibility with that library. Now the shoe is on the other foot. --- .github/workflows/compile-examples.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/compile-examples.yml b/.github/workflows/compile-examples.yml index e3e567ea9..8b4cdd433 100644 --- a/.github/workflows/compile-examples.yml +++ b/.github/workflows/compile-examples.yml @@ -248,7 +248,8 @@ jobs: - name: LoRa - name: MKRWAN - name: WiFiNINA - - name: AceTime + - name: AceTime@1.4.1 + - name: AceCommon@1.3.1 - source-url: https://github.com/vidor-libraries/VidorPeripherals.git platforms: | # Use Board Manager to install the latest release of Arduino SAMD Boards to get the toolchain