Skip to content

v1.2.0 breaks matrix.clear() when using Arduino R4 LED Matrix with matrix.set(...) #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
stefanmarks opened this issue Jun 9, 2024 · 0 comments · Fixed by #335
Closed

v1.2.0 breaks matrix.clear() when using Arduino R4 LED Matrix with matrix.set(...) #336

stefanmarks opened this issue Jun 9, 2024 · 0 comments · Fixed by #335
Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Comments

@stefanmarks
Copy link
Contributor

stefanmarks commented Jun 9, 2024 •
edited by per1234
Loading

The v1.2.0 update of the Arduino LED Matrix library broke the clear() command in that it clears the frame buffer, but not the canvas buffer.

That was previously done (admittedly in a crude way) by setting all pixels off one by one in the base ArduinoGraphics class, but does not happen anymore in the overridden method.
A simple additional memset() in clear() should resolve this issue.
@stefanmarks stefanmarks mentioned this issue Jun 9, 2024
Merged
@stefanmarks stefanmarks changed the title v1.2.0 breaks using Arduino R4 LED Matrix via matrix.clear(), matrix.set(...) v1.2.0 breaks matrix.clear() when using Arduino R4 LED Matrix with matrix.set(...) Jun 9, 2024
@per1234 per1234 linked a pull request Jun 9, 2024 that will close this issue
Clearing canvas buffer in ArduinoLEDMatrix::clear() in addition to frame buffer #335
Merged
@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: code Related to content of the project itself labels Jun 9, 2024
@per1234 per1234 added the conclusion: resolved Issue was resolved label Jun 10, 2024
@per1234 per1234 mentioned this issue Aug 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
2 participants
@per1234 @stefanmarks