Skip to content

Ethernet library - wrong ordering of begin parameters #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JAndrassy opened this issue Dec 19, 2023 · 2 comments · Fixed by #222
Closed

Ethernet library - wrong ordering of begin parameters #215

JAndrassy opened this issue Dec 19, 2023 · 2 comments · Fixed by #222
Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Comments

@JAndrassy
Copy link
Contributor

The 'begin versions without MAC address parameter have new ordering of parameters.
You can't do this. There are other Ethernet libraries now which have begin without the MAC address parameter, but they use the same ordering of parameters as the version with MAC address.
Yes a network engineer would prefer ip, subnet, gateway, dns, but Arduino introduced in 2008 an ordering based on optional parameters defaults, where it is more likely to need to set a specific DNS IP and then a specific gateway more likely then a subnet other than the default. Doing this in different ordering doesn't make sense.

@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: code Related to content of the project itself labels Dec 20, 2023
@per1234 per1234 changed the title Ethetnet - wrong ordering of begin parameters Ethernet library - wrong ordering of begin parameters Dec 20, 2023
@JAndrassy
Copy link
Contributor Author

JAndrassy commented Dec 21, 2023

I found out that the Ethernet library here is a copy of the STM32 Arduino Ethernet library and the wrong ordering originates there

@JAndrassy
Copy link
Contributor Author

PR #222

@per1234 per1234 linked a pull request Dec 22, 2023 that will close this issue
@per1234 per1234 added the conclusion: resolved Issue was resolved label Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants