Skip to content

LwIPClient.setTimeout shadows Stream.setTimeout #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JAndrassy opened this issue Sep 8, 2023 · 0 comments · Fixed by #141
Closed

LwIPClient.setTimeout shadows Stream.setTimeout #127

JAndrassy opened this issue Sep 8, 2023 · 0 comments · Fixed by #141
Assignees
@pennam
Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Comments

@JAndrassy
Copy link
Contributor

LwIPClient has setTimeout instead of setConnectionTimeout. setTimeout shadows Stream.setTimeout
@facchinm facchinm added the type: imperfection Perceived defect in any part of project label Sep 8, 2023
@per1234 per1234 added the topic: code Related to content of the project itself label Sep 12, 2023
@pennam pennam mentioned this issue Sep 21, 2023
Merged
@per1234 per1234 added the conclusion: resolved Issue was resolved label Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pennam pennam

Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Avoid shadowing Stream.setTimeout pennam/ArduinoCore-renesas
4 participants
@per1234 @facchinm @JAndrassy @pennam