Skip to content

Commit 027656d

Browse files
authored
Merge pull request #284 from pennam/fix-redefinition
WiFiS3 Udp, Client: avoid RX_BUFFER_DIM redefinition
2 parents 938d343 + 3bd177c commit 027656d

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

Diff for: libraries/WiFiS3/src/WiFiClient.h

+1-2
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,6 @@
3030
#include "FifoBuffer.h"
3131
#include <memory>
3232

33-
#define RX_BUFFER_DIM 1024
34-
3533
class WiFiClient : public Client {
3634

3735
public:
@@ -74,6 +72,7 @@ class WiFiClient : public Client {
7472
int _sock;
7573
int _connectionTimeout = 0;
7674
void getSocket();
75+
static constexpr uint32_t RX_BUFFER_DIM = 1024;
7776
std::shared_ptr<FifoBuffer<uint8_t,RX_BUFFER_DIM>> rx_buffer;
7877
int _read();
7978
void read_if_needed(size_t s);

Diff for: libraries/WiFiS3/src/WiFiUdp.h

+1-2
Original file line numberDiff line numberDiff line change
@@ -30,11 +30,10 @@
3030
#include "Modem.h"
3131
#include "FifoBuffer.h"
3232

33-
#define RX_BUFFER_DIM 1461
34-
3533
class WiFiUDP : public UDP {
3634
private:
3735
int _sock;
36+
static constexpr uint32_t RX_BUFFER_DIM = 1461;
3837
FifoBuffer<uint8_t,RX_BUFFER_DIM> rx_buffer;
3938

4039
protected:

0 commit comments

Comments
 (0)