Skip to content

SocketWrapper library: MbedClient.setTimeout shadows Stream.setTimeout #728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JAndrassy opened this issue Sep 22, 2023 · 2 comments · Fixed by #769
Closed

SocketWrapper library: MbedClient.setTimeout shadows Stream.setTimeout #728

JAndrassy opened this issue Sep 22, 2023 · 2 comments · Fixed by #769

Comments

@JAndrassy
Copy link
Contributor

MbedClient has setTimeout instead of setConnectionTimeout. setTimeout shadows Stream.setTimeout
@JAndrassy JAndrassy changed the title MbedClient.setTimeout shadows Stream.setTimeout SocketWrapper libray: MbedClient.setTimeout shadows Stream.setTimeout Sep 23, 2023
@JAndrassy JAndrassy changed the title SocketWrapper libray: MbedClient.setTimeout shadows Stream.setTimeout SocketWrapper library: MbedClient.setTimeout shadows Stream.setTimeout Sep 23, 2023
@pennam pennam mentioned this issue Nov 22, 2023
Merged
@JAndrassy
Copy link
Contributor Author

JAndrassy commented Nov 22, 2023 •
edited
Loading

Meanwhile I tested this timeout and it doesn't work for connect. It is not possible to do timeout on connect with Mbed.

I would recommend to rename to function to SetSocketTimeout

@pennam
Copy link
Contributor

pennam commented Nov 22, 2023 •
edited
Loading

Meanwhile I tested this timeout and it doesn't work for connect. It is not possible to do timeout on connect with Mbed.

I've not tested it, but i think this is the reason ARMmbed/mbed-os#13056 (comment)

I would recommend to rename to function to SetSocketTimeout

Got it! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SocketWrapper: avoid Stream setTimeout shadowing pennam/ArduinoCore-mbed
2 participants
@JAndrassy @pennam