Should arduino::MbedI2C::read() return -1 if there is no data available?

[carlosperate]

Assuming arduino/reference-en#897 in the docs repo is correct, it looks like arduino::MbedI2C::read() should be returning -1 instead of 0 at the end of the method:

ArduinoCore-mbed/libraries/Wire/Wire.cpp

Lines 119 to 124 in 949c70c

	int arduino::MbedI2C::read() {
	if (rxBuffer.available()) {
	return rxBuffer.read_char();
	}
	return 0;
	}

As reference, these implementations return -1:

• Any ArduinoCore using the ArduinoCore-API RingBuffer for the rx buffer: https://github.com/arduino/ArduinoCore-API/blob/master/api/RingBuffer.h#L96
• ArduinoCore-sam: https://github.com/arduino/ArduinoCore-sam/blob/master/libraries/Wire/src/Wire.cpp#L289
• ArduinoCore-avr: https://github.com/arduino/ArduinoCore-avr/blob/42fa4a1ea1b1b11d1cc0a60298e529d37f9d14bd/libraries/Wire/src/Wire.cpp#L293

[facchinm]

Hi @carlosperate , you are very right indeed 🙂
Would you mind submitting a PR so we can give proper attribution for the fix? Thx

[carlosperate]

Sure thing! I'll create one between tonight and tomorrow 👍