Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit e4bec35

Browse files
committedJul 9, 2024·
Fix compatibility with Ethernet.begin(nullptr) by removing begin(const char* hostname) method.
1 parent 74a9a6d commit e4bec35

File tree

2 files changed

+0
-7
lines changed

2 files changed

+0
-7
lines changed
 

‎libraries/Ethernet/src/Ethernet.cpp

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -29,12 +29,6 @@ int arduino::EthernetClass::setHostname(const char* hostname) {
2929
return 1;
3030
}
3131

32-
int arduino::EthernetClass::begin(const char* hostname) {
33-
eth_if->set_hostname(hostname);
34-
auto ret = begin();
35-
return ret;
36-
}
37-
3832
int arduino::EthernetClass::begin(uint8_t *mac, IPAddress ip) {
3933
IPAddress dns = ip;
4034
dns[3] = 1;

‎libraries/Ethernet/src/Ethernet.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,6 @@ class EthernetClass : public MbedSocketClass {
6363
// gain the rest of the configuration through DHCP.
6464
// Returns 0 if the DHCP configuration failed, and 1 if it succeeded
6565
int begin(uint8_t *mac = nullptr, unsigned long timeout = 60000, unsigned long responseTimeout = 4000);
66-
int begin(const char* hostname);
6766
EthernetLinkStatus linkStatus();
6867
EthernetHardwareStatus hardwareStatus();
6968

0 commit comments

Comments
 (0)
Please sign in to comment.