Skip to content

Commit cd006c3

Browse files
committed
Specify sketches report input values for sketch compilation CI actions
The reliance on the `actions/upload-artifacts` action as the transfer mechanism between workflow runs means that these values will always be hardcoded into the workflow. The result is that if the default values of the inputs are changed, it breaks the workflow, even if the changes are synchronized. So it's more robust to avoid dependening on the default values.
1 parent 71aa464 commit cd006c3

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

.github/workflows/compile-examples.yml

+1
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,7 @@ jobs:
7676
sketch-paths: "${{ env.UNIVERSAL_SKETCH_PATHS }} ${{ matrix.additional-sketch-paths }}"
7777
verbose: 'false'
7878
enable-size-deltas-report: true
79+
sketches-report-path: ${{ env.SKETCHES_REPORTS_PATH }}
7980

8081
- name: Save memory usage change report as artifact
8182
if: github.event_name == 'pull_request'

.github/workflows/report-size-deltas.yml

+3
Original file line numberDiff line numberDiff line change
@@ -9,3 +9,6 @@ jobs:
99
steps:
1010
- name: Comment size deltas reports to PRs
1111
uses: arduino/report-size-deltas@main
12+
with:
13+
# The name of the workflow artifact created by the sketch compilation workflow
14+
sketches-reports-source: sketches-reports

0 commit comments

Comments
 (0)