Merge pull request #330 from facchinm/reconfigure_gpio_on_pinMode

facchinm · web-flow · commit c3765dfee52e · 2021-09-29T12:18:30.000+02:00
Make pinMode always reconfigure gpio if called explicitly
diff --git a/cores/arduino/wiring_digital.cpp b/cores/arduino/wiring_digital.cpp
@@ -52,10 +52,11 @@ void pinMode(PinName pin, PinMode mode)
 void pinMode(pin_size_t pin, PinMode mode)
 {
   mbed::DigitalInOut* gpio = digitalPinToGpio(pin);
-  if (gpio == NULL) {
-    gpio = new mbed::DigitalInOut(digitalPinToPinName(pin));
-    digitalPinToGpio(pin) = gpio;
+  if (gpio != NULL) {
+    delete gpio;
   }
+  gpio = new mbed::DigitalInOut(digitalPinToPinName(pin));
+  digitalPinToGpio(pin) = gpio;
 
   switch (mode) {
     case INPUT:

Original file line number	Diff line number	Diff line change
`@@ -52,10 +52,11 @@ void pinMode(PinName pin, PinMode mode)`
`52`	`52`	`void pinMode(pin_size_t pin, PinMode mode)`
`53`	`53`	`{`
`54`	`54`	`mbed::DigitalInOut* gpio = digitalPinToGpio(pin);`
`55`		`- if (gpio == NULL) {`
`56`		`- gpio = new mbed::DigitalInOut(digitalPinToPinName(pin));`
`57`		`- digitalPinToGpio(pin) = gpio;`
	`55`	`+ if (gpio != NULL) {`
	`56`	`+ delete gpio;`
`58`	`57`	`}`
	`58`	`+ gpio = new mbed::DigitalInOut(digitalPinToPinName(pin));`
	`59`	`+ digitalPinToGpio(pin) = gpio;`
`59`	`60`
`60`	`61`	`switch (mode) {`
`61`	`62`	`case INPUT:`