Skip to content

Commit 65de42c

Browse files
committed
nicla: Add missing return value in enterShipMode function.
1 parent 089cbe2 commit 65de42c

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

libraries/Nicla_System/src/BQ25120A.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ class BQ25120A
2626
BQ25120A() {};
2727

2828
uint8_t getStatus();
29-
void writeByte(uint8_t address, uint8_t subAddress, uint8_t data);
29+
bool writeByte(uint8_t address, uint8_t subAddress, uint8_t data);
3030
uint8_t readByte(uint8_t address, uint8_t subAddress);
3131

3232
};

libraries/Nicla_System/src/Nicla_System.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ bool nicla::enterShipMode()
9999

100100
uint8_t status_reg = _pmic.getStatus();
101101
status_reg |= 0x20;
102-
_pmic.writeByte(BQ25120A_ADDRESS, BQ25120A_STATUS, status_reg);
102+
return _pmic.writeByte(BQ25120A_ADDRESS, BQ25120A_STATUS, status_reg);
103103
}
104104

105105
uint8_t nicla::readLDOreg()

libraries/Nicla_System/src/pmic_driver.cpp

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,16 +12,17 @@ uint8_t BQ25120A::getStatus()
1212
return c;
1313
}
1414

15-
void BQ25120A::writeByte(uint8_t address, uint8_t subAddress, uint8_t data)
15+
bool BQ25120A::writeByte(uint8_t address, uint8_t subAddress, uint8_t data)
1616
{
1717
cd = 1;
1818
nicla::i2c_mutex.lock();
1919
Wire1.beginTransmission(address);
2020
Wire1.write(subAddress);
2121
Wire1.write(data);
22-
Wire1.endTransmission();
22+
uint8_t result = Wire1.endTransmission();
2323
nicla::i2c_mutex.unlock();
2424
cd = 0;
25+
return result == 0;
2526
}
2627

2728
uint8_t BQ25120A::readByte(uint8_t address, uint8_t subAddress)

0 commit comments

Comments
 (0)