Merge pull request #827 from sebromero/sebromero/ov-flip-mirror

sebromero · web-flow · commit 5af0bd7a8df7 · 2024-01-18T18:25:15.000+01:00
Implement vflip and mirror for OV cameras
diff --git a/libraries/OV7670/ov7670.cpp b/libraries/OV7670/ov7670.cpp
@@ -699,12 +699,16 @@ int OV7670::setFrameRate(int32_t framerate)
 
 int OV7670::setVerticalFlip(bool flip_enable)
 {
-  return -1;
+    uint8_t currentRegisterValue = regRead(getID(), MVFP);
+    uint8_t newRegisterValue = flip_enable ? currentRegisterValue | MVFP_VFLIP : currentRegisterValue & ~MVFP_VFLIP;
+    return regWrite(getID(), MVFP, newRegisterValue);
 }
 
 int OV7670::setHorizontalMirror(bool mirror_enable)
 {
-  return -1;
+    uint8_t currentRegisterValue = regRead(getID(), MVFP);
+    uint8_t newRegisterValue = mirror_enable ? currentRegisterValue | MVFP_MIRROR : currentRegisterValue & ~MVFP_MIRROR;
+    return regWrite(getID(), MVFP, newRegisterValue);
 }
 
 int OV7670::setResolution(int32_t resolution)

Original file line number	Diff line number	Diff line change
`@@ -699,12 +699,16 @@ int OV7670::setFrameRate(int32_t framerate)`
`699`	`699`
`700`	`700`	`int OV7670::setVerticalFlip(bool flip_enable)`
`701`	`701`	`{`
`702`		`- return -1;`
	`702`	`+ uint8_t currentRegisterValue = regRead(getID(), MVFP);`
	`703`	`+ uint8_t newRegisterValue = flip_enable ? currentRegisterValue \| MVFP_VFLIP : currentRegisterValue & ~MVFP_VFLIP;`
	`704`	`+ return regWrite(getID(), MVFP, newRegisterValue);`
`703`	`705`	`}`
`704`	`706`
`705`	`707`	`int OV7670::setHorizontalMirror(bool mirror_enable)`
`706`	`708`	`{`
`707`		`- return -1;`
	`709`	`+ uint8_t currentRegisterValue = regRead(getID(), MVFP);`
	`710`	`+ uint8_t newRegisterValue = mirror_enable ? currentRegisterValue \| MVFP_MIRROR : currentRegisterValue & ~MVFP_MIRROR;`
	`711`	`+ return regWrite(getID(), MVFP, newRegisterValue);`
`708`	`712`	`}`
`709`	`713`
`710`	`714`	`int OV7670::setResolution(int32_t resolution)`