Skip to content

Commit 967e00d

Browse files
esprengfacchinm
authored andcommitted
Mega4809 internal review (#1)
* fixed typos in UART
1 parent 0a36c2c commit 967e00d

File tree

4 files changed

+7
-10
lines changed

4 files changed

+7
-10
lines changed

Diff for: cores/arduino/UART1.cpp

+1-2
Original file line numberDiff line numberDiff line change
@@ -45,14 +45,13 @@ ISR(HWSERIAL1_RXC_VECTOR)
4545
#error "Don't know what the Data Received interrupt vector is called for Serial1"
4646
#endif
4747

48-
//!!BUG in headerfile. The RXC and DRE vectors are swapped!!
4948
#if defined(HWSERIAL1_DRE_VECTOR)
5049
ISR(HWSERIAL1_DRE_VECTOR)
5150
{
5251
Serial1._tx_data_empty_irq();
5352
}
5453
#else
55-
#error "Don't know what the Data Received interrupt vector is called for Serial"
54+
#error "Don't know what the Data Register Empty interrupt vector is called for Serial1"
5655
#endif
5756

5857
#if defined(HWSERIAL1)

Diff for: cores/arduino/UART2.cpp

+2-3
Original file line numberDiff line numberDiff line change
@@ -42,17 +42,16 @@ ISR(HWSERIAL2_RXC_VECTOR)
4242
Serial2._rx_complete_irq();
4343
}
4444
#else
45-
#error "Don't know what the Data Received interrupt vector is called for Serial1"
45+
#error "Don't know what the Data Received interrupt vector is called for Serial2"
4646
#endif
4747

48-
//!!BUG in headerfile. The RXC and DRE vectors are swapped!!
4948
#if defined(HWSERIAL2_DRE_VECTOR)
5049
ISR(HWSERIAL2_DRE_VECTOR)
5150
{
5251
Serial2._tx_data_empty_irq();
5352
}
5453
#else
55-
#error "Don't know what the Data Received interrupt vector is called for Serial"
54+
#error "Don't know what the Data Register Empty interrupt vector is called for Serial2"
5655
#endif
5756

5857
#if defined(HWSERIAL2)

Diff for: cores/arduino/UART3.cpp

+2-3
Original file line numberDiff line numberDiff line change
@@ -42,17 +42,16 @@ ISR(HWSERIAL3_RXC_VECTOR)
4242
Serial3._rx_complete_irq();
4343
}
4444
#else
45-
#error "Don't know what the Data Received interrupt vector is called for Serial1"
45+
#error "Don't know what the Data Received interrupt vector is called for Serial3"
4646
#endif
4747

48-
//!!BUG in headerfile. The RXC and DRE vectors are swapped!!
4948
#if defined(HWSERIAL3_DRE_VECTOR)
5049
ISR(HWSERIAL3_DRE_VECTOR)
5150
{
5251
Serial3._tx_data_empty_irq();
5352
}
5453
#else
55-
#error "Don't know what the Data Received interrupt vector is called for Serial"
54+
#error "Don't know what the Data Register Empty interrupt vector is called for Serial3"
5655
#endif
5756

5857
#if defined(HWSERIAL3)

Diff for: cores/arduino/UART_private.h

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
HardwareSerial_private.h - Hardware serial library for Wiring
2+
UART_private.h - Hardware serial library for Wiring
33
Copyright (c) 2006 Nicholas Zambetti. All right reserved.
44
55
This library is free software; you can redistribute it and/or
@@ -23,7 +23,7 @@
2323

2424
#include "wiring_private.h"
2525

26-
// this next line disables the entire HardwareSerial.cpp,
26+
// this next line disables the entire UART.cpp,
2727
// this is so I can support Attiny series and any other chip without a uart
2828
#if defined(HAVE_HWSERIAL0) || defined(HAVE_HWSERIAL1) || defined(HAVE_HWSERIAL2) || defined(HAVE_HWSERIAL3)
2929

0 commit comments

Comments
 (0)