Skip to content

Commit 4866d9b

Browse files
smartpersoncmaglie
authored andcommitted
Fixed Serial Port Argument That May Include Spaces
Other paths in avrdude.upload.pattern are wrapped in double quotes, and this -P{serial.port} causes issues with some platforms. This allows serial port devices which include spaces and other characters. Without this fix a /dev/tty* or /dev/cu* device that includes a space in its name gets truncated when passed to avrdude. Error messages returned from avrdude are cryptic, and workarounds (symlinks) are prone to failure. Fixes #3693
1 parent 44ce914 commit 4866d9b

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Diff for: platform.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ tools.avrdude.upload.params.quiet=-q -q
102102
# tools.avrdude.upload.verify is needed for backwards compatibility with IDE 1.6.8 or older, IDE 1.6.9 or newer overrides this value
103103
tools.avrdude.upload.verify=
104104
tools.avrdude.upload.params.noverify=-V
105-
tools.avrdude.upload.pattern="{cmd.path}" "-C{config.path}" {upload.verbose} {upload.verify} -p{build.mcu} -c{upload.protocol} -P{serial.port} -b{upload.speed} -D "-Uflash:w:{build.path}/{build.project_name}.hex:i"
105+
tools.avrdude.upload.pattern="{cmd.path}" "-C{config.path}" {upload.verbose} {upload.verify} -p{build.mcu} -c{upload.protocol} "-P{serial.port}" -b{upload.speed} -D "-Uflash:w:{build.path}/{build.project_name}.hex:i"
106106

107107
tools.avrdude.program.params.verbose=-v
108108
tools.avrdude.program.params.quiet=-q -q

0 commit comments

Comments
 (0)