Skip to content

Commit 4729181

Browse files
committed
Replacing bit operations macros with bit macro
Signed-off-by: José Luis Di Biase <[email protected]>
1 parent eabd762 commit 4729181

File tree

1 file changed

+6
-7
lines changed

1 file changed

+6
-7
lines changed

Diff for: cores/arduino/Arduino.h

+6-7
Original file line numberDiff line numberDiff line change
@@ -108,11 +108,12 @@ void yield(void);
108108
#define lowByte(w) ((uint8_t) ((w) & 0xff))
109109
#define highByte(w) ((uint8_t) ((w) >> 8))
110110

111-
#define bitRead(value, bit) (((value) >> (bit)) & 0x01)
112-
#define bitSet(value, bit) ((value) |= (1UL << (bit)))
113-
#define bitClear(value, bit) ((value) &= ~(1UL << (bit)))
114-
#define bitToggle(value, bit) ((value) ^= (1UL << (bit)))
115-
#define bitWrite(value, bit, bitvalue) ((bitvalue) ? bitSet(value, bit) : bitClear(value, bit))
111+
#define bit(b) (1UL << (b))
112+
#define bitRead(value, b) (((value) >> (b)) & 0x01)
113+
#define bitSet(value, b) ((value) |= bit(b))
114+
#define bitClear(value, b) ((value) &= ~bit(b))
115+
#define bitToggle(value, b) ((value) ^= bit(b))
116+
#define bitWrite(value, b, bitvalue) ((bitvalue) ? bitSet(value, b) : bitClear(value, b))
116117

117118
// avr-libc defines _NOP() since 1.6.2
118119
#ifndef _NOP
@@ -121,8 +122,6 @@ void yield(void);
121122

122123
typedef unsigned int word;
123124

124-
#define bit(b) (1UL << (b))
125-
126125
typedef bool boolean;
127126
typedef uint8_t byte;
128127

0 commit comments

Comments
 (0)