Note on IPv4 tests to int32_t

sgryphon · sgryphon · commit 606d3a81ea5a · 2022-08-15T10:55:44.000+10:00
diff --git a/test/src/IPAddress/test_operator_assignment.cpp b/test/src/IPAddress/test_operator_assignment.cpp
@@ -29,5 +29,6 @@ TEST_CASE ("Testing IPAddress::operator = (uint32_t a)", "[IPAddress-Operator-=-
   uint32_t const ip2 = 192 | (168 << 8) | (1 << 16) | (2 << 24);
 
   ip1 = ip2;
+  // NOTE: Only correct on little-endian systems
   REQUIRE(ip1 == arduino::IPAddress(192,168,1,2));
 }
diff --git a/test/src/IPAddress/test_operator_parentheses.cpp b/test/src/IPAddress/test_operator_parentheses.cpp
@@ -19,5 +19,6 @@ TEST_CASE ("Testing IPAddress::operator uint32_t() const", "[IPAddress-Operator-
   arduino::IPAddress ip(129,168,1,2);
   uint32_t const val_expected = ip;
   uint32_t const val_actual = (129 | (168 << 8) | (1 << 16) | (2 << 24));
+  // NOTE: Only correct on little-endian systems
   REQUIRE(val_expected == val_actual);
 }

Original file line number	Diff line number	Diff line change
`@@ -29,5 +29,6 @@ TEST_CASE ("Testing IPAddress::operator = (uint32_t a)", "[IPAddress-Operator-=-`
`29`	`29`	`uint32_t const ip2 = 192 \| (168 << 8) \| (1 << 16) \| (2 << 24);`
`30`	`30`
`31`	`31`	`ip1 = ip2;`
	`32`	`+ // NOTE: Only correct on little-endian systems`
`32`	`33`	`REQUIRE(ip1 == arduino::IPAddress(192,168,1,2));`
`33`	`34`	`}`
Original file line number	Diff line number	Diff line change
`@@ -19,5 +19,6 @@ TEST_CASE ("Testing IPAddress::operator uint32_t() const", "[IPAddress-Operator-`
`19`	`19`	`arduino::IPAddress ip(129,168,1,2);`
`20`	`20`	`uint32_t const val_expected = ip;`
`21`	`21`	`uint32_t const val_actual = (129 \| (168 << 8) \| (1 << 16) \| (2 << 24));`
	`22`	`+ // NOTE: Only correct on little-endian systems`
`22`	`23`	`REQUIRE(val_expected == val_actual);`
`23`	`24`	`}`