Skip to content

Add font size shortcuts (menu and keyboard) #6394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

gdyr
Copy link
Contributor

@gdyr gdyr commented Jun 18, 2017

Having a stab at #6359.
(Scaling font size using keyboard shortcuts.)

I haven't implemented Ctrl-Scroll, but have implemented keyboard shortcuts using the existing menu item pattern.

Let me know if I should go about this a different way!

screen shot 2017-06-18 at 7 17 06 pm

@facchinm
Copy link
Member

@ArduinoBot build this please

Copy link
Member

@facchinm facchinm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the patch is super cool, just a couple of problems we need to solve with shortcuts and then I think we can merge it 👍

@@ -1374,6 +1374,24 @@ public void actionPerformed(ActionEvent e) {

menu.addSeparator();

JMenuItem increaseFontSizeItem = newJMenuItem(tr("Increase Font Size"), '=');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why didn't you choose ctrl + '+' as increase shortcut? The = version doesn't seem to work with an Italian keyboard (since = can only be reached with Maiusc modifier)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! I hadn't thought about other keyboards.
One convention I'm familiar with is to use - and = to avoid having to use a shift key to increase but not decrease the font size. (Plus can only be used with a shift modifier on a US keyboard.)

Perhaps ctrl + '+' should be the primary shortcut and ctrl + '=' be secondary?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could work, I'm ccing our UX designer for an advice 🙂 @00alis

@facchinm
Copy link
Member

Superseded by #6551

@facchinm facchinm closed this Jul 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants