Subtract one from USB_EP_SIZE in USB_SendSpace #4864
Conversation
This avoids dealing with ZLP’s in USB_Send, because the max packet size will be EP size - 1.
sandeepmistry
added
feature request
|
✅ Build completed. Please test this code using one of the following: ⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-4864-BUILD-552-linux32.tar.xz ℹ️ The |
|
Was this internally discussed and tested? |
|
@NicoHood Yes, tested by me on Ubuntu and Windows. If you can also try it out is good :) |
|
A user reported that this PR breaks the raw hid code: The ZLP needs to be handled inside the Serial, not the USB-Core. Please revert this commit and think of another solution. This possibly also breaks other USB libs. |
|
@NicoHood thanks for letting us know. Do you have any suggestions on how to move forward? Please note, the SAMD core has the same behaviour as this PR: arduino/ArduinoCore-samd@40d9554. |
|
No I dont know how to solve this problem, but I remember that there were multiple solutions provided. I'd revert the PR for now, as this is defenitely implemented wrong and needs to move to the serial library, not the usb core. |
This avoids dealing with ZLP’s in
USB_Send, because the max packet size will be EP size - 1.Alternative to #4138 to resolve #3946.
cc/ @NicoHood @embmicro @BlackBrix.