Skip to content

WCharacter.h and ctype.h function definitions conflict... [imported] #830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cmaglie opened this issue Nov 15, 2012 · 0 comments
Closed
Labels
Type: Invalid Off topic for this repository, or a bug report determined to not actually represent a bug

Comments

@cmaglie
Copy link
Member

cmaglie commented Nov 15, 2012

This is Issue 830 moved from a Google Code project.
Added by 2012-02-25T07:46:26.000Z by [email protected].
Please review that bug for more context and additional comments, but update this bug.
Closed (Invalid).

Original labels: Type-Defect, Priority-Medium

Original description

WCharacter.h (part of Arduino) contains a bunch of isXXXX() function definitions that are also defined in ctype.h, which it includes. But the Arduino definitions return "boolean", while ctype.h (and apparently the C99 standard) definitions use "int."

This does not seem to create problems now, but there are some indications on other platforms that this will result in errors under future versions of the compiler and/or fussier reporting modes.

If WCharacter.h is going to implement inline versions of the libc functions, it should do so with standards-compatible prototypes...

@cmaglie cmaglie closed this as completed Nov 15, 2012
@per1234 per1234 added the Type: Invalid Off topic for this repository, or a bug report determined to not actually represent a bug label Jul 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Invalid Off topic for this repository, or a bug report determined to not actually represent a bug
Projects
None yet
Development

No branches or pull requests

2 participants