Skip to content

narrowing conversion was warning, now is error #7944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
PaulStoffregen opened this issue Aug 29, 2018 · 2 comments
Closed

narrowing conversion was warning, now is error #7944

PaulStoffregen opened this issue Aug 29, 2018 · 2 comments
Labels
Component: Compilation Related to compilation of Arduino sketches
Milestone

Comments

@PaulStoffregen
Copy link
Contributor

PaulStoffregen commented Aug 29, 2018

The recent upgrade from gcc 4.8 to 5.4 has turned "narrowing conversion" from a warning to an error.

Here is a library which demonstrates the problem. Works with earlier Arduino but will not compile with 1.8.6.

https://github.com/nathanRamaNoodles/MusicWithoutDelay-LIbrary

I recommend adding "-Wno-error=narrowing" to the compiler flags in platform.txt for compiling .cpp files. This will restore the gcc 4.8 behavior and allow libraries like MusicWithoutDelay to compile as they always have on prior versions of Arduino.

@per1234 per1234 added the Component: Compilation Related to compilation of Arduino sketches label Aug 29, 2018
@facchinm facchinm added this to the Release 1.8.7 milestone Aug 29, 2018
@chammie
Copy link

chammie commented Aug 29, 2018

I found the same problem

@PaulStoffregen
Copy link
Contributor Author

Tested hourly build just now. Confirmed this is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Compilation Related to compilation of Arduino sketches
Projects
None yet
Development

No branches or pull requests

4 participants