Skip to content

IPAddress missing definition of operator!= and may cause incorrect behaviour #7336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ssilverman opened this issue Mar 16, 2018 · 3 comments
Closed

IPAddress missing definition of operator!= and may cause incorrect behaviour #7336

ssilverman opened this issue Mar 16, 2018 · 3 comments
Labels
Print and Stream class The Arduino core library's Print and Stream classes

Comments

@ssilverman
Copy link

Defining operator!= is needed to do comparisons like a != b. Otherwise, code comparing inequality of IPAddresses needs to do !(a == b).
@ssilverman ssilverman mentioned this issue Mar 16, 2018
Closed
@facchinm facchinm added the Print and Stream class The Arduino core library's Print and Stream classes label Mar 19, 2018
@ssilverman
Copy link
Author

ssilverman commented Oct 30, 2018 •
edited
Loading

A request: would you mind adding the commit this was fixed in? I can't seem to find any code changes.

@matthijskooijman
Copy link
Collaborator

Did you look in the arduino core avr repo? It has a separate repository these days.

@facchinm
Copy link
Member

Hi @ssilverman ,
sorry for the confusion, it was the automatic github issue closer in action 🙂 The commit is arduino/ArduinoCore-API@d5ae3fa (we are still preparing the official release)

This was referenced Sep 15, 2021
Merged
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Print and Stream class The Arduino core library's Print and Stream classes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@matthijskooijman @ssilverman @facchinm