Skip to content

Hardwareserial: Disable interrupts while setting TXC bit #6685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
NicoHood opened this issue Sep 1, 2017 · 2 comments
Closed

Hardwareserial: Disable interrupts while setting TXC bit #6685

NicoHood opened this issue Sep 1, 2017 · 2 comments
Labels
Component: HardwareSerial The hardware serial functionality of the core libraries Type: Duplicate Another item already exists for this topic

Comments

@NicoHood
Copy link
Contributor

NicoHood commented Sep 1, 2017

As discussed here the TXC bit setting should be atomic. Otherwise other (non usart) interrupts may corrupt the hardwareserial flush() function.
@per1234 per1234 added the Component: HardwareSerial The hardware serial functionality of the core libraries label Sep 1, 2017
@NicoHood
Copy link
Contributor Author

seems to be the same issue as #3745 with already opened pr by me long time ago #3865

@matthijskooijman
Copy link
Collaborator

I'm closing this as a duplicate, since though even though #3745 was opened for a different issue (double transmissions), its discussion has broadened to include this flush lockup issue too.

@matthijskooijman matthijskooijman added the Type: Duplicate Another item already exists for this topic label Sep 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: HardwareSerial The hardware serial functionality of the core libraries Type: Duplicate Another item already exists for this topic
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@matthijskooijman @NicoHood @per1234