Skip to content

Tab names are not allowed to start with a number #6656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
per1234 opened this issue Aug 26, 2017 · 1 comment
Closed

Tab names are not allowed to start with a number #6656

per1234 opened this issue Aug 26, 2017 · 1 comment
Labels
Component: IDE user interface The Arduino IDE's user interface feature request A request to make an enhancement (not a bug fix)
Milestone
Release 1.8.5

Comments

@per1234
Copy link
Collaborator

per1234 commented Aug 26, 2017

4545283 made it so that sketch names starting with a number are now allowed but New Tab still doesn't allow a number to be entered as the first character of the tab name.

Originally reported at: http://forum.arduino.cc/index.php?topic=496959
@per1234 per1234 added Component: IDE user interface The Arduino IDE's user interface feature request A request to make an enhancement (not a bug fix) labels Aug 26, 2017
@per1234 per1234 changed the title Tabs are not allowed to start with a number Tab names are not allowed to start with a number Aug 26, 2017
@cmaglie
Copy link
Member

cmaglie commented Aug 28, 2017

Thanks, now is fixed.

BTW I'm not fully satisfied with the solution since JTextBox implements his own validation logic, this must be refactored to use the BaseNoGui.sanitizedName() method to validate the input.

@cmaglie cmaglie added this to the Release 1.8.5 milestone Aug 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: IDE user interface The Arduino IDE's user interface feature request A request to make an enhancement (not a bug fix)
Projects
None yet
Milestone
Release 1.8.5
Development

No branches or pull requests
2 participants
@cmaglie @per1234